Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Environments not store their own Repo objects #407

Merged
merged 1 commit into from
Jun 3, 2016

Conversation

pv
Copy link
Collaborator

@pv pv commented May 4, 2016

Environment only needs to know about a Repo when it is building a
project. Pass the repository in as an argument when needed.

The actual issue this fixes is to avoid cloning the repository when it
is not necessary, for example in 'asv run --python=same'.
(The cloning in this case is a regression introduced in gh-352)

  • WIP: may still need some testing

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 70.299% when pulling 8aa4461 on pv:avoid-clone into f5d916c on spacetelescope:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 70.112% when pulling 438dbb8 on pv:avoid-clone into 7c72fc0 on spacetelescope:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 70.251% when pulling 01bfa3d on pv:avoid-clone into 1a4afff on spacetelescope:master.

Environment only needs to know about a Repo when it is building a
project. Pass the repository in as an argument when needed.

The actual issue this fixes is to avoid cloning the repository when it
is not necessary, for example in 'asv run --python=same'.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 70.391% when pulling d8544d6 on pv:avoid-clone into bea2cbd on spacetelescope:master.

@pv pv merged commit 1123313 into airspeed-velocity:master Jun 3, 2016
@pv
Copy link
Collaborator Author

pv commented Jun 3, 2016

Merging, should be OK.

@pv pv deleted the avoid-clone branch August 19, 2018 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants