Add a command-line option for selecting environments #352
Conversation
| @@ -311,7 +359,8 @@ def hashname(self): | |||
| """ | |||
| Get a hash to uniquely identify this environment. | |||
| """ | |||
| return hashlib.md5(self.name.encode('utf-8')).hexdigest() | |||
| full_name = "{0}-{1}".format(self.tool_name, self.name).encode('utf-8') | |||
There was a problem hiding this comment.
Would it make sense to just have tool_name included as part of the name property -- since tool_name is now required to uniquely identify the environment...
|
Looks good, other than my one comment above. |
|
@pv: Sorry I've been incommunicado here for so long. Want to fix the minor issue, rebase and I'll merge? |
This enables choosing between conda and virtualenv without having to edit the configuration file. It also allows specifying the python interpreter used by ExistingEnvironment. This supercedes the --python PY option, which becomes equivalent to --environment=:PY.
|
No problem, updated. The environment tool name is now included also in the result file names. |
|
@mdboom: can you enable rolling builds http://www.appveyor.com/docs/build-configuration#rolling-builds cf appveyor/ci#38 in appveyor, so that it behaves more sensibly vs. updated PRs? The option probably should be somewhere in the appveyor UI, can't be specified in config file... |
|
Merged. I also enabled rolling builds on appveyor. |
Add a command-line option
--environment(or-E) for selecting what environment type and Python version to run, overriding what is specified in the configuration file.--pythonoption, and makes it possible to specify what Python executable to run using ExistingEnvironment (which was not possible previously).tool_nameto the hash-name of the environments, so that it's possible to have conda and virtualenv at the same time without conflicts.environment.get_environmentsto the top-level command classes. (Previously, environments were instantiated inBenchmarksfor benchmark discovery.)Some fine tuning may still be needed (although this is in principle complete)