Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Convert almost everything to f-strings #1258

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

HaoZeke
Copy link
Member

@HaoZeke HaoZeke commented Mar 25, 2023

With flynt. Superceedes #1198, #1197, #1196, #1245.

@mattip
Copy link
Contributor

mattip commented Apr 23, 2023

This has a merge conflict

@mattip
Copy link
Contributor

mattip commented Apr 23, 2023

Does this take into account the comments in #1245?

@HaoZeke
Copy link
Member Author

HaoZeke commented Apr 23, 2023

Does this take into account the comments in #1245?

Yup, most of them are not relevant since extern has been removed. However, for this:

Nit: it is a bit weird to be using these old versions of python (line 39?) and numpy (dunno where that comes from). If not too much trouble could you update them? If not no big deal.

I'm not sure they should be updated here, since those are part of the asv files generated for the tests, made an issue for updating them, #1280.

@mattip mattip merged commit df82301 into airspeed-velocity:master Apr 24, 2023
@mattip
Copy link
Contributor

mattip commented Apr 24, 2023

Thanks @HaoZeke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants