Use fstrings #1245
Closed
Use fstrings #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattip
reviewed
Feb 20, 2023
| @@ -2295,7 +2295,7 @@ def print_profiles(self, w=0, cutoff=0, **print3options): | |||
| linesep, w, len(t), _plural(len(t)), s, self._incl, **print3options) | |||
| r = len(t) | |||
| for v, k in sorted(t, reverse=True): | |||
| s = 'object%(plural)s: %(total)s, %(avg)s, %(high)s: %(obj)s%(lengstr)s' % v.format(self._clip_, self._total) | |||
| s = f"object{v.format(self._clip_, self._total)['plural']}: {v.format(self._clip_, self._total)['total']}, {v.format(self._clip_, self._total)['avg']}, {v.format(self._clip_, self._total)['high']}: {v.format(self._clip_, self._total)['obj']}{v.format(self._clip_, self._total)['lengstr']}" | |||
There was a problem hiding this comment.
Either revert this or reformat refactor it: the newer code is worse than the old
mattip
reviewed
Feb 20, 2023
| @@ -2889,7 +2889,7 @@ def refs(obj, **opts): | |||
| _printf('%s%d type definitions: %s and %s, kind ... %s', linesep, | |||
| n, 'basic-', 'itemsize (leng)', '-type[def]s') | |||
| for k, v in sorted((_prepr(k), v) for k, v in _items(_typedefs)): | |||
| s = '%(base)s and %(item)s%(leng)s, %(kind)s%(code)s' % v.format() | |||
| s = f"{v.format()['base']} and {v.format()['item']}{v.format()['leng']}, {v.format()['kind']}{v.format()['code']}" | |||
There was a problem hiding this comment.
Either revert or refactor, the new code is worse than the old.
mattip
reviewed
Feb 20, 2023
| @@ -138,7 +138,7 @@ def test_get_result_hash_from_prefix(tmpdir): | |||
| shutil.copyfile(machine_json, join(str(machine_dir), 'machine.json')) | |||
|
|
|||
| for f in ['e5b6cdbc', 'e5bfoo12']: | |||
| open(join(str(machine_dir), '{0}-py2.7-Cython-numpy1.8.json'.format(f)), 'a').close() | |||
| open(join(str(machine_dir), f'{f}-py2.7-Cython-numpy1.8.json'), 'a').close() | |||
There was a problem hiding this comment.
Nit: it is a bit weird to be using these old versions of python (line 39?) and numpy (dunno where that comes from). If not too much trouble could you update them? If not no big deal.
mattip
reviewed
Feb 20, 2023
|
Superseded by #1258 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.