ENH: Handle default branch #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoZeke
force-pushed
the
handleDefaultBranch
branch
from
02d1c1c to
a734887
Compare
HaoZeke
commented
Jan 2, 2023
| try: | ||
| self._default_branch = self._run_git(['config', | ||
| 'init.defaultBranch', | ||
| ], display_error=False, |
There was a problem hiding this comment.
Without display_error=False, tests which capture stderr and stdout to test against reference strings fail.
|
A late comment now that I'm seeing this: conceptually this isn't quite right. I'd think it would be a lot easier to just add the config value to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1231. The general implementation is essentially EAFP and is a little clunky, but hopefully at some point the entire
git.pyplugin will go away in favor of say, pygit2.Some implementation details are highlighted in the comments.