BUG: Allow tag commit hashes for graphs #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a test failure on appveyor. Thoughts? |
|
On PR #1221 the github CI also failed, but appveyor passed. |
Sorry, yes I'll need to update the tests. |
|
There are some linting failures after #1229 |
|
... and a failing test |
HaoZeke
force-pushed
the
fixTagCommits
branch
3 times, most recently
from
6ff9d49
to
9b44340
Compare
|
Still failing CI ... |
Sorry, had to setup #1232 before I could debug this properly, will rebase with a fix in a bit. |
mattip
reviewed
Jan 2, 2023
| branch = self.run_git(["config", "init.defaultBranch"], | ||
| display_error=False).strip() | ||
| except util.ProcessError: | ||
| branch = 'master' |
There was a problem hiding this comment.
At some point it might be nice to refactor this into a helper function
|
Thanks @HaoZeke |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1226.
cc @mattip