-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Allow tag commit hashes for graphs #1227
Conversation
There is a test failure on appveyor. Thoughts? |
On PR #1221 the github CI also failed, but appveyor passed. |
Sorry, yes I'll need to update the tests. |
There are some linting failures after #1229 |
... and a failing test |
6ff9d49
to
9b44340
Compare
Still failing CI ... |
Sorry, had to setup #1232 before I could debug this properly, will rebase with a fix in a bit. |
branch = self.run_git(["config", "init.defaultBranch"], | ||
display_error=False).strip() | ||
except util.ProcessError: | ||
branch = 'master' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point it might be nice to refactor this into a helper function
Thanks @HaoZeke |
Closes #1226.
cc @mattip