Helm Chart: Create service annotations for airbyte-server #17932

sfc-gh-pkommini · 2022-10-13T06:02:51Z

Support annotations for airbyte-server
Update helm version
Update docs

The PR is the same as PR#12981 but for the airbyte-server for parity with airbyte-webapp.

What

Problem right now is that webapp service has support for annotations but server service has not support for annotations.

How

It will allow configurations such as for the webapp and server helm charts:

webapp:
  ingress:
    enabled: true

  service:
    annotations:
      alb.ingress.kubernetes.io/healthcheck-path: /index.html
      alb.ingress.kubernetes.io/healthcheck-port: traffic-port

server:
  service:
    annotations:
      alb.ingress.kubernetes.io/healthcheck-path: /api/v1/health
      alb.ingress.kubernetes.io/healthcheck-port: traffic-port

🚨 User Impact 🚨

No breaking changes. Defaults to empty annotations {}. So it can be deployed without any annotations.

…date docs.

CLAassistant · 2022-10-13T06:02:57Z

All committers have signed the CLA.

sfc-gh-pkommini · 2022-10-13T06:05:48Z

@alafanechere Could you review this? Asking as you merged a similar PR.

…nto create-service-annotations

marcosmarxm · 2022-10-13T16:07:06Z

@sfc-gh-pkommini I requested to @xpuska513 to review your contribution. Thanks for it!

xpuska513

LGTM

* Support annotations for airbyte-server as well, update version and update docs. * Fix auto-indent. Co-authored-by: Kyryl Skobylko <[email protected]>

* Implement ColumnSortButton component * Updates component name; Moves component to ui/Table folder; Refactors formattedMessageId property into using render content as children directly; Removes minor SortIcon component * Update airbyte-webapp/src/App.tsx Co-authored-by: Edmundo Ruiz Ghanem <[email protected]> * Updates next properties: wasActive -> isActive, lowToLarge -> isAscending * Skip psql stop in acceptance test for gke (#18023) * Checks for iterator hasNext element (#18041) * Checks for iterator hasNext element * Fix linter with newline * Add Message Migration to Destination Connection Checks (#17954) * Add Message Migration to Destination Connection Checks * Fix test setup * Update helm release workflow (#18048) * Update workflow * Update trigger rules * fix: Update release workflow with abillity to add tags * Update workflow * Remove unused `airbyte-cli` (#18009) * 🐛 [low-code] $options shouldn't overwrite values that are already defined (#18060) * fix * Add missing test * remove prints * extract to method * rename * Add missing test * rename * bump * Update helm chart comments (#18072) * Update helm charts (#18073) * add test * fix chart.yaml * 16250 Destination Redis: Add SSH support (#17951) * 16250 Destination Redis: Add SSH support * 16250 Resolve port issue * 11679 Bump version * auto-bump connector version Co-authored-by: Octavia Squidington III <[email protected]> * Bump helm chart version reference to 0.40.20 (#18074) * Bump helm chart version reference to 0.40.20 * remove binary Co-authored-by: xpuska513 <[email protected]> Co-authored-by: Kyryl Skobylko <[email protected]> * Helm Chart: Create service annotations for airbyte-server (#17932) * Support annotations for airbyte-server as well, update version and update docs. * Fix auto-indent. Co-authored-by: Kyryl Skobylko <[email protected]> * Bmoric/remove dep server worker (#17894) * test [ci skip] * Autogenerated files * Add missing annotation * Remove unused json2Schema block from worker * Move tess * Missing deps and format * Fix test build * TMP * Add missing dependencies * PR comments * Tmp * [ci skip] Tmp * Fix acceptance test and add the seed dependency * Fix build * For diff * tmp * Build pass * make the worker to be on the platform only * fix setting.yaml * Fix pmd * Fix Cron * Add chart * Fix cron * Fix server build.gradle * Fix jar conflict * PR comments * Add cron micronaut environemnt * Updated connector catalog page (#18076) * Move the port forward outside of the main docker-compose (#17864) * Bump Airbyte version from 0.40.14 to 0.40.15 (#17970) Co-authored-by: benmoriceau <[email protected]> * 🎉 Source Shopify: Add metafield streams (#17962) * 🎉 Source Shopify: Add metafield streams * Source Shopify: fix unittest * Source Shopify: docs update * Source Shopify: fix backward compatibility test * Source Shopify: fix schemas * Source Shopify: fix state filter * Source Shopify: refactor & optimize * Source Shopify: fix test privileges * Source Shopify: fix stream filter * Source Shopify: fix streams * Source Shopify: update abnormal state * Source Shopify: fix abnormal state streams * Source Shopify: fix streams * updated methods, formated code * Source Shopify: typo fix * auto-bump connector version Co-authored-by: Oleksandr Bazarnov <[email protected]> Co-authored-by: Octavia Squidington III <[email protected]> * fix check for streams that do not use a stream slicer (#18080) * fix check for streams that do not use a stream slicer * increment version and changelog before publish * tolerate database nulls in webhook operation configs (#18084) * Implement webhook operation in the sync workflow (#18022) Implements the webhook operation as part of the sync workflow. - Introduces the new activity implementation - Updates the various interfaces that pass input to get the relevant configs to the sync workflow - Hooks the new activity into the sync workflow - Passes the webhook configs along into the sync workflow job * Bump helm chart version reference to 0.40.22 (#18077) * Added new "filters" python file, along with a "hash" filter. This can… (#18000) * Added new "filters" python file, along with a "hash" filter. This can be extended to include other custom filters in the future. * Added additional comments * Moved usage of the hash_obj inside the conditional that confirms it exists * Moved the hash function call inside a condition to ensure that it exists * Fixed the application of the salt , so that it does not modify the hash unless it is actually passed in. * Added unit tests to validate new jinja hash functionality * Updated unit test to pass numeric value as a float instead of string * Removed unreferenced import to pytest * Updated version * format * format * format * format * format Co-authored-by: Alexandre Girard <[email protected]> * Bump helm chart version reference to 0.40.24 (#18081) * Bump helm chart version reference to 0.40.24 * Update .gitignore Co-authored-by: benmoriceau <[email protected]> Co-authored-by: Kyryl Skobylko <[email protected]> * SATs: allow new records in a sequential read for full refresh test (#17660) * SATs: allow new records in a sequential read for full refresh test * SATs: upd changelog * SATs: change the output when failing full refresh test * SATs: upd according to code review * Source facebook-marketing: remove `pixel` from custom conversions stream (#18045) * #744 source facebook-marketing: rm pixel from custom conversions stream * #744 source fb marketing: upd changelog * #744 source facebook-marketing - add custom_conversions to the test catalog * auto-bump connector version Co-authored-by: Octavia Squidington III <[email protected]> * #17506 fix klaviyo & marketo expected_records (#18101) Co-authored-by: Edmundo Ruiz Ghanem <[email protected]> Co-authored-by: terencecho <[email protected]> Co-authored-by: Ryan Fu <[email protected]> Co-authored-by: Jimmy Ma <[email protected]> Co-authored-by: Kyryl Skobylko <[email protected]> Co-authored-by: Evan Tahler <[email protected]> Co-authored-by: Alexandre Girard <[email protected]> Co-authored-by: Yevhen Sukhomud <[email protected]> Co-authored-by: Octavia Squidington III <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: xpuska513 <[email protected]> Co-authored-by: Prasanth <[email protected]> Co-authored-by: Benoit Moriceau <[email protected]> Co-authored-by: Amruta Ranade <[email protected]> Co-authored-by: Octavia Squidington III <[email protected]> Co-authored-by: benmoriceau <[email protected]> Co-authored-by: Artem Inzhyyants <[email protected]> Co-authored-by: Oleksandr Bazarnov <[email protected]> Co-authored-by: Brian Lai <[email protected]> Co-authored-by: Michael Siega <[email protected]> Co-authored-by: Alexander Marquardt <[email protected]> Co-authored-by: Denys Davydov <[email protected]>

…17932) * Support annotations for airbyte-server as well, update version and update docs. * Fix auto-indent. Co-authored-by: Kyryl Skobylko <[email protected]>

* Implement ColumnSortButton component * Updates component name; Moves component to ui/Table folder; Refactors formattedMessageId property into using render content as children directly; Removes minor SortIcon component * Update airbyte-webapp/src/App.tsx Co-authored-by: Edmundo Ruiz Ghanem <[email protected]> * Updates next properties: wasActive -> isActive, lowToLarge -> isAscending * Skip psql stop in acceptance test for gke (airbytehq#18023) * Checks for iterator hasNext element (airbytehq#18041) * Checks for iterator hasNext element * Fix linter with newline * Add Message Migration to Destination Connection Checks (airbytehq#17954) * Add Message Migration to Destination Connection Checks * Fix test setup * Update helm release workflow (airbytehq#18048) * Update workflow * Update trigger rules * fix: Update release workflow with abillity to add tags * Update workflow * Remove unused `airbyte-cli` (airbytehq#18009) * 🐛 [low-code] $options shouldn't overwrite values that are already defined (airbytehq#18060) * fix * Add missing test * remove prints * extract to method * rename * Add missing test * rename * bump * Update helm chart comments (airbytehq#18072) * Update helm charts (airbytehq#18073) * add test * fix chart.yaml * 16250 Destination Redis: Add SSH support (airbytehq#17951) * 16250 Destination Redis: Add SSH support * 16250 Resolve port issue * 11679 Bump version * auto-bump connector version Co-authored-by: Octavia Squidington III <[email protected]> * Bump helm chart version reference to 0.40.20 (airbytehq#18074) * Bump helm chart version reference to 0.40.20 * remove binary Co-authored-by: xpuska513 <[email protected]> Co-authored-by: Kyryl Skobylko <[email protected]> * Helm Chart: Create service annotations for airbyte-server (airbytehq#17932) * Support annotations for airbyte-server as well, update version and update docs. * Fix auto-indent. Co-authored-by: Kyryl Skobylko <[email protected]> * Bmoric/remove dep server worker (airbytehq#17894) * test [ci skip] * Autogenerated files * Add missing annotation * Remove unused json2Schema block from worker * Move tess * Missing deps and format * Fix test build * TMP * Add missing dependencies * PR comments * Tmp * [ci skip] Tmp * Fix acceptance test and add the seed dependency * Fix build * For diff * tmp * Build pass * make the worker to be on the platform only * fix setting.yaml * Fix pmd * Fix Cron * Add chart * Fix cron * Fix server build.gradle * Fix jar conflict * PR comments * Add cron micronaut environemnt * Updated connector catalog page (airbytehq#18076) * Move the port forward outside of the main docker-compose (airbytehq#17864) * Bump Airbyte version from 0.40.14 to 0.40.15 (airbytehq#17970) Co-authored-by: benmoriceau <[email protected]> * 🎉 Source Shopify: Add metafield streams (airbytehq#17962) * 🎉 Source Shopify: Add metafield streams * Source Shopify: fix unittest * Source Shopify: docs update * Source Shopify: fix backward compatibility test * Source Shopify: fix schemas * Source Shopify: fix state filter * Source Shopify: refactor & optimize * Source Shopify: fix test privileges * Source Shopify: fix stream filter * Source Shopify: fix streams * Source Shopify: update abnormal state * Source Shopify: fix abnormal state streams * Source Shopify: fix streams * updated methods, formated code * Source Shopify: typo fix * auto-bump connector version Co-authored-by: Oleksandr Bazarnov <[email protected]> Co-authored-by: Octavia Squidington III <[email protected]> * fix check for streams that do not use a stream slicer (airbytehq#18080) * fix check for streams that do not use a stream slicer * increment version and changelog before publish * tolerate database nulls in webhook operation configs (airbytehq#18084) * Implement webhook operation in the sync workflow (airbytehq#18022) Implements the webhook operation as part of the sync workflow. - Introduces the new activity implementation - Updates the various interfaces that pass input to get the relevant configs to the sync workflow - Hooks the new activity into the sync workflow - Passes the webhook configs along into the sync workflow job * Bump helm chart version reference to 0.40.22 (airbytehq#18077) * Added new "filters" python file, along with a "hash" filter. This can… (airbytehq#18000) * Added new "filters" python file, along with a "hash" filter. This can be extended to include other custom filters in the future. * Added additional comments * Moved usage of the hash_obj inside the conditional that confirms it exists * Moved the hash function call inside a condition to ensure that it exists * Fixed the application of the salt , so that it does not modify the hash unless it is actually passed in. * Added unit tests to validate new jinja hash functionality * Updated unit test to pass numeric value as a float instead of string * Removed unreferenced import to pytest * Updated version * format * format * format * format * format Co-authored-by: Alexandre Girard <[email protected]> * Bump helm chart version reference to 0.40.24 (airbytehq#18081) * Bump helm chart version reference to 0.40.24 * Update .gitignore Co-authored-by: benmoriceau <[email protected]> Co-authored-by: Kyryl Skobylko <[email protected]> * SATs: allow new records in a sequential read for full refresh test (airbytehq#17660) * SATs: allow new records in a sequential read for full refresh test * SATs: upd changelog * SATs: change the output when failing full refresh test * SATs: upd according to code review * Source facebook-marketing: remove `pixel` from custom conversions stream (airbytehq#18045) * airbytehq#744 source facebook-marketing: rm pixel from custom conversions stream * airbytehq#744 source fb marketing: upd changelog * airbytehq#744 source facebook-marketing - add custom_conversions to the test catalog * auto-bump connector version Co-authored-by: Octavia Squidington III <[email protected]> * #17506 fix klaviyo & marketo expected_records (airbytehq#18101) Co-authored-by: Edmundo Ruiz Ghanem <[email protected]> Co-authored-by: terencecho <[email protected]> Co-authored-by: Ryan Fu <[email protected]> Co-authored-by: Jimmy Ma <[email protected]> Co-authored-by: Kyryl Skobylko <[email protected]> Co-authored-by: Evan Tahler <[email protected]> Co-authored-by: Alexandre Girard <[email protected]> Co-authored-by: Yevhen Sukhomud <[email protected]> Co-authored-by: Octavia Squidington III <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: xpuska513 <[email protected]> Co-authored-by: Prasanth <[email protected]> Co-authored-by: Benoit Moriceau <[email protected]> Co-authored-by: Amruta Ranade <[email protected]> Co-authored-by: Octavia Squidington III <[email protected]> Co-authored-by: benmoriceau <[email protected]> Co-authored-by: Artem Inzhyyants <[email protected]> Co-authored-by: Oleksandr Bazarnov <[email protected]> Co-authored-by: Brian Lai <[email protected]> Co-authored-by: Michael Siega <[email protected]> Co-authored-by: Alexander Marquardt <[email protected]> Co-authored-by: Denys Davydov <[email protected]>

sfc-gh-pkommini added 2 commits October 12, 2022 22:43

Support annotations for airbyte-server as well, update version and up…

250637c

…date docs.

Fix auto-indent.

1d39ed2

github-actions bot added area/platform issues related to the platform kubernetes labels Oct 13, 2022

octavia-squidington-iv added the community label Oct 13, 2022

Merge branch 'master' of https://github.com/sfc-gh-pkommini/airbyte i…

d2eee3b

…nto create-service-annotations

marcosmarxm requested a review from xpuska513 October 13, 2022 16:06

sfc-gh-pkommini changed the title ~~Create service annotations~~ Helm Chart: Create service annotations for airbyte-server Oct 13, 2022

xpuska513 approved these changes Oct 17, 2022

View reviewed changes

Merge branch 'master' into create-service-annotations

4e57963

xpuska513 merged commit 211b4be into airbytehq:master Oct 17, 2022

github-actions bot mentioned this pull request Oct 17, 2022

Bump helm chart version reference to 0.40.22 #18077

Merged

octavia-squidington-iii mentioned this pull request Oct 20, 2022

Bump Airbyte version from 0.40.15 to 0.40.16 #18268

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Helm Chart: Create service annotations for airbyte-server #17932

Helm Chart: Create service annotations for airbyte-server #17932

sfc-gh-pkommini commented Oct 13, 2022 •

edited

Loading

CLAassistant commented Oct 13, 2022 •

edited

Loading

sfc-gh-pkommini commented Oct 13, 2022

marcosmarxm commented Oct 13, 2022

xpuska513 left a comment

Helm Chart: Create service annotations for airbyte-server #17932

Helm Chart: Create service annotations for airbyte-server #17932

Conversation

sfc-gh-pkommini commented Oct 13, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

CLAassistant commented Oct 13, 2022 • edited Loading

sfc-gh-pkommini commented Oct 13, 2022

marcosmarxm commented Oct 13, 2022

xpuska513 left a comment

Choose a reason for hiding this comment

sfc-gh-pkommini commented Oct 13, 2022 •

edited

Loading

CLAassistant commented Oct 13, 2022 •

edited

Loading