🪟 🧹 Implement ColumnSortButton component #17798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
|
Please still add a more descriptive PR description to this including some screenshots. |
edmundito
reviewed
Oct 17, 2022
| lowToLarge: boolean; | ||
| } | ||
|
|
||
| export const ColumnSortButton: React.FC<ColumnSortButtonProps> = ({ |
There was a problem hiding this comment.
This is not just the button but also contains the text of the heading, the name should be SortableTableHeader. This should also be part of the Table export, so it's probably best if it goes into components/ui/Table
| lowToLarge, | ||
| }) => ( | ||
| <button className={styles.sortButton} onClick={onClick}> | ||
| <FormattedMessage id={formattedMessageId} /> |
There was a problem hiding this comment.
The preference is not to pass the messageId but instead just pass the content, so one suggestion is to make this {children} and let the user of this component add <FormattedMessage id="...." /> as the child.
| lowToLarge: boolean; | ||
| } | ||
|
|
||
| export const ColumnSortButton: React.FC<ColumnSortButtonProps> = ({ |
There was a problem hiding this comment.
If we're using the children as suggested below, in order to make this compatible with React 18:
Suggested change
| export const ColumnSortButton: React.FC<ColumnSortButtonProps> = ({ | |
| export const ColumnSortButton: React.FC<React.PropsWithChildren<ColumnSortButtonProps>> = ({ |
| }) => ( | ||
| <button className={styles.sortButton} onClick={onClick}> | ||
| <FormattedMessage id={formattedMessageId} /> | ||
| <SortIcon wasActive={wasActive} lowToLarge={lowToLarge} /> |
There was a problem hiding this comment.
Is it necessary to have a sort icon component file? It looks like it's very simple and it could be implemented here.
YatsukBogdan1
changed the title
… formattedMessageId property into using render content as children directly; Removes minor SortIcon component
edmundito
reviewed
Oct 17, 2022
Comment on lines
9
to
10
| wasActive: boolean; | ||
| lowToLarge: boolean; |
There was a problem hiding this comment.
I noticed that these names came from the old component but they could be more clear:
wasActive => isActive
lowToLarge => isAscending
There was a problem hiding this comment.
Agree, need to rename this couple
|
Reviewed the PR after fixes due to @edmundito comments Code - LGTM. |
Co-authored-by: Edmundo Ruiz Ghanem <[email protected]>
* Checks for iterator hasNext element * Fix linter with newline
* Add Message Migration to Destination Connection Checks * Fix test setup
* Update workflow * Update trigger rules * fix: Update release workflow with abillity to add tags * Update workflow
…ined (#18060) * fix * Add missing test * remove prints * extract to method * rename * Add missing test * rename * bump
* add test * fix chart.yaml
* 16250 Destination Redis: Add SSH support * 16250 Resolve port issue * 11679 Bump version * auto-bump connector version Co-authored-by: Octavia Squidington III <[email protected]>
* Bump helm chart version reference to 0.40.20 * remove binary Co-authored-by: xpuska513 <[email protected]> Co-authored-by: Kyryl Skobylko <[email protected]>
* Support annotations for airbyte-server as well, update version and update docs. * Fix auto-indent. Co-authored-by: Kyryl Skobylko <[email protected]>
* test [ci skip] * Autogenerated files * Add missing annotation * Remove unused json2Schema block from worker * Move tess * Missing deps and format * Fix test build * TMP * Add missing dependencies * PR comments * Tmp * [ci skip] Tmp * Fix acceptance test and add the seed dependency * Fix build * For diff * tmp * Build pass * make the worker to be on the platform only * fix setting.yaml * Fix pmd * Fix Cron * Add chart * Fix cron * Fix server build.gradle * Fix jar conflict * PR comments * Add cron micronaut environemnt
Co-authored-by: benmoriceau <[email protected]>
|
|
|
NOTE
|
github-actions
bot
removed
area/worker
edmundito
approved these changes
Oct 18, 2022
dizel852
approved these changes
Oct 18, 2022
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* Implement ColumnSortButton component * Updates component name; Moves component to ui/Table folder; Refactors formattedMessageId property into using render content as children directly; Removes minor SortIcon component * Update airbyte-webapp/src/App.tsx Co-authored-by: Edmundo Ruiz Ghanem <[email protected]> * Updates next properties: wasActive -> isActive, lowToLarge -> isAscending * Skip psql stop in acceptance test for gke (airbytehq#18023) * Checks for iterator hasNext element (airbytehq#18041) * Checks for iterator hasNext element * Fix linter with newline * Add Message Migration to Destination Connection Checks (airbytehq#17954) * Add Message Migration to Destination Connection Checks * Fix test setup * Update helm release workflow (airbytehq#18048) * Update workflow * Update trigger rules * fix: Update release workflow with abillity to add tags * Update workflow * Remove unused `airbyte-cli` (airbytehq#18009) * 🐛 [low-code] $options shouldn't overwrite values that are already defined (airbytehq#18060) * fix * Add missing test * remove prints * extract to method * rename * Add missing test * rename * bump * Update helm chart comments (airbytehq#18072) * Update helm charts (airbytehq#18073) * add test * fix chart.yaml * 16250 Destination Redis: Add SSH support (airbytehq#17951) * 16250 Destination Redis: Add SSH support * 16250 Resolve port issue * 11679 Bump version * auto-bump connector version Co-authored-by: Octavia Squidington III <[email protected]> * Bump helm chart version reference to 0.40.20 (airbytehq#18074) * Bump helm chart version reference to 0.40.20 * remove binary Co-authored-by: xpuska513 <[email protected]> Co-authored-by: Kyryl Skobylko <[email protected]> * Helm Chart: Create service annotations for airbyte-server (airbytehq#17932) * Support annotations for airbyte-server as well, update version and update docs. * Fix auto-indent. Co-authored-by: Kyryl Skobylko <[email protected]> * Bmoric/remove dep server worker (airbytehq#17894) * test [ci skip] * Autogenerated files * Add missing annotation * Remove unused json2Schema block from worker * Move tess * Missing deps and format * Fix test build * TMP * Add missing dependencies * PR comments * Tmp * [ci skip] Tmp * Fix acceptance test and add the seed dependency * Fix build * For diff * tmp * Build pass * make the worker to be on the platform only * fix setting.yaml * Fix pmd * Fix Cron * Add chart * Fix cron * Fix server build.gradle * Fix jar conflict * PR comments * Add cron micronaut environemnt * Updated connector catalog page (airbytehq#18076) * Move the port forward outside of the main docker-compose (airbytehq#17864) * Bump Airbyte version from 0.40.14 to 0.40.15 (airbytehq#17970) Co-authored-by: benmoriceau <[email protected]> * 🎉 Source Shopify: Add metafield streams (airbytehq#17962) * 🎉 Source Shopify: Add metafield streams * Source Shopify: fix unittest * Source Shopify: docs update * Source Shopify: fix backward compatibility test * Source Shopify: fix schemas * Source Shopify: fix state filter * Source Shopify: refactor & optimize * Source Shopify: fix test privileges * Source Shopify: fix stream filter * Source Shopify: fix streams * Source Shopify: update abnormal state * Source Shopify: fix abnormal state streams * Source Shopify: fix streams * updated methods, formated code * Source Shopify: typo fix * auto-bump connector version Co-authored-by: Oleksandr Bazarnov <[email protected]> Co-authored-by: Octavia Squidington III <[email protected]> * fix check for streams that do not use a stream slicer (airbytehq#18080) * fix check for streams that do not use a stream slicer * increment version and changelog before publish * tolerate database nulls in webhook operation configs (airbytehq#18084) * Implement webhook operation in the sync workflow (airbytehq#18022) Implements the webhook operation as part of the sync workflow. - Introduces the new activity implementation - Updates the various interfaces that pass input to get the relevant configs to the sync workflow - Hooks the new activity into the sync workflow - Passes the webhook configs along into the sync workflow job * Bump helm chart version reference to 0.40.22 (airbytehq#18077) * Added new "filters" python file, along with a "hash" filter. This can… (airbytehq#18000) * Added new "filters" python file, along with a "hash" filter. This can be extended to include other custom filters in the future. * Added additional comments * Moved usage of the hash_obj inside the conditional that confirms it exists * Moved the hash function call inside a condition to ensure that it exists * Fixed the application of the salt , so that it does not modify the hash unless it is actually passed in. * Added unit tests to validate new jinja hash functionality * Updated unit test to pass numeric value as a float instead of string * Removed unreferenced import to pytest * Updated version * format * format * format * format * format Co-authored-by: Alexandre Girard <[email protected]> * Bump helm chart version reference to 0.40.24 (airbytehq#18081) * Bump helm chart version reference to 0.40.24 * Update .gitignore Co-authored-by: benmoriceau <[email protected]> Co-authored-by: Kyryl Skobylko <[email protected]> * SATs: allow new records in a sequential read for full refresh test (airbytehq#17660) * SATs: allow new records in a sequential read for full refresh test * SATs: upd changelog * SATs: change the output when failing full refresh test * SATs: upd according to code review * Source facebook-marketing: remove `pixel` from custom conversions stream (airbytehq#18045) * airbytehq#744 source facebook-marketing: rm pixel from custom conversions stream * airbytehq#744 source fb marketing: upd changelog * airbytehq#744 source facebook-marketing - add custom_conversions to the test catalog * auto-bump connector version Co-authored-by: Octavia Squidington III <[email protected]> * #17506 fix klaviyo & marketo expected_records (airbytehq#18101) Co-authored-by: Edmundo Ruiz Ghanem <[email protected]> Co-authored-by: terencecho <[email protected]> Co-authored-by: Ryan Fu <[email protected]> Co-authored-by: Jimmy Ma <[email protected]> Co-authored-by: Kyryl Skobylko <[email protected]> Co-authored-by: Evan Tahler <[email protected]> Co-authored-by: Alexandre Girard <[email protected]> Co-authored-by: Yevhen Sukhomud <[email protected]> Co-authored-by: Octavia Squidington III <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: xpuska513 <[email protected]> Co-authored-by: Prasanth <[email protected]> Co-authored-by: Benoit Moriceau <[email protected]> Co-authored-by: Amruta Ranade <[email protected]> Co-authored-by: Octavia Squidington III <[email protected]> Co-authored-by: benmoriceau <[email protected]> Co-authored-by: Artem Inzhyyants <[email protected]> Co-authored-by: Oleksandr Bazarnov <[email protected]> Co-authored-by: Brian Lai <[email protected]> Co-authored-by: Michael Siega <[email protected]> Co-authored-by: Alexander Marquardt <[email protected]> Co-authored-by: Denys Davydov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Close #17062 and #17491
How
There was already a codebase prepared for this, but it wasn't organized into a single component, so this PR adds a new
SortableHeaderComponentthat is located insideui/Tablefolder