Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[low code connectors] add missing/mistyped values for declarative sendgrid + sentry #15734

Merged
merged 6 commits into from
Aug 17, 2022
Merged

[low code connectors] add missing/mistyped values for declarative sendgrid + sentry #15734

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
afbe2bd
add missing/mistyped values for declarative sendgrid + sentry
brianjlai Aug 17, 2022
1a66386
bump docker versions and add changelog
brianjlai Aug 17, 2022
1afcde9
auto-bump connector version [ci skip]
octavia-squidington-iii Aug 17, 2022
68ebcd1
auto-bump connector version [ci skip]
octavia-squidington-iii Aug 17, 2022
e3c0ff6
Merge branch 'brian/fix_schema_for_published_declarative_sources' of …
octavia-squidington-iii Aug 17, 2022
6e01ad2
Merge branch 'master' into brian/fix_schema_for_published_declarative…
brianjlai Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion airbyte-integrations/connectors/source-sendgrid/source_sendgrid/sendgrid.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
version: "0.1.0"
definitions:
page_size: 50
step: "30d"
Expand Down Expand Up @@ -247,7 +248,7 @@ streams:
$ref: "*ref(definitions.requester)"
request_options_provider:
request_parameters:
limit: 1000
limit: "1000"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alternative to this, is we change the type of RequestInput from RequestInput = Union[str, Mapping[str, str]] to RequestInput = Union[str, Mapping[str, Any]]. That would then make 1000 a valid input

query: 'last_event_time BETWEEN TIMESTAMP "{{stream_slice.start_time}}" AND TIMESTAMP "{{stream_slice.end_time}}"'
stream_slicer:
$ref: "*ref(definitions.messages_stream_slicer)"
Expand Down
1 change: 1 addition & 0 deletions airbyte-integrations/connectors/source-sentry/source_sentry/sentry.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
version: "0.1.0"
definitions:
page_size: 50
schema_loader:
Expand Down