Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[low code connectors] add missing/mistyped values for declarative sendgrid + sentry #15734

Merged
merged 6 commits into from
Aug 17, 2022
Merged

[low code connectors] add missing/mistyped values for declarative sendgrid + sentry #15734

merged 6 commits into from
Aug 17, 2022

Conversation

brianjlai
Copy link
Contributor

What

After running schema validation against our existing connectors, there were a few small things that got flagged. These should be fixed before we merge the validation code, otherwise we'll break our daily connector testing

How

A few connectors were missing version, and we should be sending all query parameters as strings as per our type definition

@brianjlai brianjlai requested a review from girarda August 17, 2022 19:20
@brianjlai brianjlai changed the title add missing/mistyped values for declarative sendgrid + sentry [low code connectors] add missing/mistyped values for declarative sendgrid + sentry Aug 17, 2022
@github-actions github-actions bot added the area/connectors Connector related issues label Aug 17, 2022
brianjlai
brianjlai commented Aug 17, 2022
View reviewed changes
airbyte-integrations/connectors/source-sendgrid/source_sendgrid/sendgrid.yaml
@@ -247,7 +248,7 @@ streams:
$ref: "*ref(definitions.requester)"
request_options_provider:
request_parameters:
limit: 1000
limit: "1000"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alternative to this, is we change the type of RequestInput from RequestInput = Union[str, Mapping[str, str]] to RequestInput = Union[str, Mapping[str, Any]]. That would then make 1000 a valid input

girarda
girarda approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming the acceptance tests pass

@brianjlai
Copy link
Contributor Author

brianjlai commented Aug 17, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-sendgrid

🕑 connectors/source-sendgrid https://github.com/airbytehq/airbyte/actions/runs/2877879606
✅ connectors/source-sendgrid https://github.com/airbytehq/airbyte/actions/runs/2877879606
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_sendgrid/source.py         4      0   100%
source_sendgrid/__init__.py       2      0   100%
-------------------------------------------------
TOTAL                             6      0   100%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1321    463    65%

Build Passed

Test summary info:

All Passed

@brianjlai
Copy link
Contributor Author

brianjlai commented Aug 17, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-sentry

🕑 connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/2877880296
✅ connectors/source-sentry https://github.com/airbytehq/airbyte/actions/runs/2877880296
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1321    463    65%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 26 passed, 1 skipped in 32.52s ========================

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Aug 17, 2022
@brianjlai
Copy link
Contributor Author

brianjlai commented Aug 17, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-sendgrid

🕑 Publishing the following connectors:
connectors/source-sendgrid
https://github.com/airbytehq/airbyte/actions/runs/2878181549


Connector Did it publish? Were definitions generated?
connectors/source-sendgrid ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@brianjlai
Copy link
Contributor Author

brianjlai commented Aug 17, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-sentry

🕑 Publishing the following connectors:
connectors/source-sentry
https://github.com/airbytehq/airbyte/actions/runs/2878183520


Connector Did it publish? Were definitions generated?
connectors/source-sentry ❌ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@brianjlai
Copy link
Contributor Author

brianjlai commented Aug 17, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-sentry

🕑 Publishing the following connectors:
connectors/source-sentry
https://github.com/airbytehq/airbyte/actions/runs/2878306215


Connector Did it publish? Were definitions generated?
connectors/source-sentry ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets August 17, 2022 21:21 Inactive
@brianjlai brianjlai merged commit 78af792 into master Aug 17, 2022
@brianjlai brianjlai deleted the brian/fix_schema_for_published_declarative_sources branch August 17, 2022 22:08
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Aug 19, 2022
Closed
@evantahler evantahler mentioned this pull request Aug 22, 2022
Merged
rodireich pushed a commit that referenced this pull request Aug 25, 2022
@brianjlai @octavia-squidington-iii @rodireich
[low code connectors] add missing/mistyped values for declarative sen…
768d7db 
…dgrid + sentry (#15734)

* add missing/mistyped values for declarative sendgrid + sentry

* bump docker versions and add changelog

* auto-bump connector version [ci skip]

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girarda girarda girarda approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/sendgrid connectors/source/sentry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brianjlai @girarda @octavia-squidington-iii