🪟 🐛 Fix input validation on blur and cleanup signup error handling #14724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
reviewed
Jul 14, 2022
| onFocus={onInputFocusChange} | ||
| onBlur={onInputFocusChange} | ||
| onFocus={(event) => { | ||
| toggleFocused(); |
There was a problem hiding this comment.
Since we're touching this right now: Could we maybe change this useToggle into a useState and actually use onFocus/onBlur to set the focused state correctly. Most of the times it shouldn't be a problem, but I've encountered in the past some weird edge-cases where onFocus/onBlur might be called twice (e.g. when browser window focus changes in a weird way), in which case the toggle solution might lose correct track of actual focus.
timroes
approved these changes
Jul 14, 2022
jsrcodes
added a commit
to jsrcodes/airbyte
that referenced
this pull request
Jul 15, 2022
…rbytehq-master * 'master' of https://github.com/airbytehq/airbyte: (1141 commits) pass USE_STREAM_CAPABLE_STATE env var to containers/deployments (airbytehq#14737) Bump mqtt connector (airbytehq#14648) Add error code to ManualOperationResult (airbytehq#14657) Bump elasticsearch version (airbytehq#14640) Ryan/sync oracle version number (airbytehq#14736) Fixed linter issue with add_fields.py comments (airbytehq#14742) 🎉Redshift, Databricks, Snowflake, S3 Destinations: Make S3 output filename configurable (airbytehq#14494) 🐛Source-mssql: aligned regular and cdc syncs and its datatype tests (airbytehq#14379) 🎉 Source Amazon Seller Partner: Add new streams (airbytehq#13604) bump source-file-secure (airbytehq#14704) 🎉 New source: Timely airbytehq#13292 (airbytehq#14335) 🪟🔧 Refactor feature service (airbytehq#14559) [low code cdk] add a transformation for adding fields into an outgoing record (airbytehq#14638) Bump destination-postgres to 0.3.21 (airbytehq#14479) Remove `additionalProperties: false` from JDBC destination connectors (airbytehq#14618) 🎉 Source Notion: add OAuth authorization for source-notion connector (airbytehq#14706) Use the configuration diff calculation in the update endpoint (airbytehq#14626) 🪟 🐛 Fix input validation on blur and cleanup signup error handling (airbytehq#14724) lower sleep after wait for successful job (airbytehq#14725) Add configuration diff (airbytehq#14603) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #14727
This fixes an issue related to input validation not handling the focus/blur events correctly, causing the form validation messages to not appear when the form is set to validate on blur. Caused by #12398
Originally started as an issue with signup not showing errors, it also cleans up the error messages there as well.
How
Inputcomponent has a custom onFocus onBlur events to handle highlight the input on focus/blur, but it needs to propagate the event if the parent is assigning these events, which Formik does through the Field component.LabeledInputcomponent was a mess with the props and noticed this while inspecting the form so it's cleaned upRecommended reading order
Top top bottom