Update Input password component layout to avoid password manager button overlap with visibility button #12398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update layout to prevent password manager buttons from overlapping with visiblity button * Apply consistent layout to both password and non-password inputs
github-actions
bot
added
area/frontend
area/platform
timroes
reviewed
Apr 27, 2022
| data-testid="input" | ||
| /> | ||
| {isVisibilityButtonVisible ? ( | ||
| <VisibilityButton |
There was a problem hiding this comment.
Since this is an icon only button, could we still attach an aria-label to it with "Toggle password visibility" (or the like)
edmundito
force-pushed
the
fix-pwd-input-vis-btn
branch
from
baabcbc
to
2c47718
Compare
* Fix type issues with testutils render
krishnaglick
approved these changes
Apr 29, 2022
This was referenced May 2, 2022
suhomud
pushed a commit
that referenced
this pull request
May 23, 2022
…on overlap with visibility button (#12398) * Update Input password component visibilty button * Update layout to prevent password manager buttons from overlapping with visiblity button * Apply consistent layout to both password and non-password inputs * Add Input component unit test * Update InputProps to interface * Ensure input component can be assigned type * Add aria label to visiblity button in password input * Fix type issues with testutils render
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #12202
This fixes an issue where a password manager's button would overlap with the password field's show/hide password button.
Before:
After:
How
Updates how the Input field is laid out. Instead of having the button overlap the input, the input is not split into two parts wrapped around a container.
Also added a unit test to test the behavior of the input component.