Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAT: cause AirbyteTraceMessage by using invalid sync mode #12960

Merged
merged 4 commits into from
May 18, 2022
Merged

SAT: cause AirbyteTraceMessage by using invalid sync mode #12960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9ff634
cause failure by using invalid sync mode
pedroslopez May 18, 2022
caa5932
create configured stream without passing pydantic validation
pedroslopez May 18, 2022
1d610d1
fix formatting
pedroslopez May 18, 2022
e730a86
bump version, update changelog
pedroslopez May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions airbyte-integrations/bases/source-acceptance-test/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## 0.1.54
Fixed `AirbyteTraceMessage` test case to make connectors fail more reliably.

## 0.1.53
Add more granular incremental testing that walks through syncs and verifies records according to cursor value.

Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/bases/source-acceptance-test/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ COPY pytest.ini setup.py ./
COPY source_acceptance_test ./source_acceptance_test
RUN pip install .

LABEL io.airbyte.version=0.1.53
LABEL io.airbyte.version=0.1.54
LABEL io.airbyte.name=airbyte/source-acceptance-test

ENTRYPOINT ["python", "-m", "pytest", "-p", "source_acceptance_test.plugin", "-r", "fEsx"]
8 changes: 4 additions & 4 deletions airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
ConfiguredAirbyteCatalog,
ConfiguredAirbyteStream,
ConnectorSpecification,
DestinationSyncMode,
Status,
SyncMode,
TraceType,
Expand Down Expand Up @@ -419,14 +418,15 @@ def test_airbyte_trace_message_on_failure(self, connector_config, inputs: BasicR

invalid_configured_catalog = ConfiguredAirbyteCatalog(
streams=[
ConfiguredAirbyteStream(
# create ConfiguredAirbyteStream without validation
ConfiguredAirbyteStream.construct(
stream=AirbyteStream(
name="__AIRBYTE__stream_that_does_not_exist",
json_schema={"type": "object", "properties": {"f1": {"type": "string"}}},
supported_sync_modes=[SyncMode.full_refresh],
),
sync_mode=SyncMode.full_refresh,
destination_sync_mode=DestinationSyncMode.overwrite,
sync_mode="INVALID",
destination_sync_mode="INVALID",
Comment on lines +428 to +429
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, those are invalid alight!

)
]
)
Expand Down