-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAT: cause AirbyteTraceMessage
by using invalid sync mode
#12960
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
/test connector=source-google-sheets
|
Looks like the
And for stripe:
|
/test connector=source-facebook-marketing
|
source-facebook-marketing failure is unrelated to the new test case |
sync_mode="INVALID", | ||
destination_sync_mode="INVALID", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, those are invalid alight!
40c3875
to
e730a86
Compare
/publish connector=bases/source-acceptance-test auto-bump-version=false
|
* cause failure by using invalid sync mode * create configured stream without passing pydantic validation * fix formatting * bump version, update changelog
What
The test case introduced in #12796 assumed that connectors will fail/crash if given a non-existent stream name as part of the configured catalog. However, this was not necessarily the case (for example, google sheets does not do this and instead exits silently). We should make this fail more reliably.
How
In addition to supplying an invalid stream name, also supply invalid sync modes so validation should not pass.