Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote and comma-separate Pokemon examples to clarify help text #12942

Merged
merged 3 commits into from
May 18, 2022
Merged

Quote and comma-separate Pokemon examples to clarify help text #12942

merged 3 commits into from
May 18, 2022

Conversation

evantahler
Copy link
Contributor

Closes #12792

@github-actions github-actions bot added the area/connectors Connector related issues label May 17, 2022
@evantahler evantahler marked this pull request as ready for review May 17, 2022 22:28
@evantahler
Copy link
Contributor Author

evantahler commented May 17, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-pokeapi

🕑 connectors/source-pokeapi https://github.com/airbytehq/airbyte/actions/runs/2341759935
✅ connectors/source-pokeapi https://github.com/airbytehq/airbyte/actions/runs/2341759935
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        76      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_incremental.py        85     25    71%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  923    246    73%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestSpec.test_config_match_spec because not found in the config
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 10 passed, 2 skipped in 4.12s =========================

@evantahler
Copy link
Contributor Author

evantahler commented May 18, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-pokeapi

🕑 connectors/source-pokeapi https://github.com/airbytehq/airbyte/actions/runs/2348679878
✅ connectors/source-pokeapi https://github.com/airbytehq/airbyte/actions/runs/2348679878
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestSpec.test_config_match_spec because not found in the config
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 10 passed, 2 skipped in 4.08s =========================

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label May 18, 2022
@evantahler
Copy link
Contributor Author

evantahler commented May 18, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-pokeapi

🕑 connectors/source-pokeapi https://github.com/airbytehq/airbyte/actions/runs/2348725135
🚀 Successfully published connectors/source-pokeapi
🚀 Auto-bumped version for connectors/source-pokeapi
✅ connectors/source-pokeapi https://github.com/airbytehq/airbyte/actions/runs/2348725135

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets May 18, 2022 23:33 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets May 18, 2022 23:33 Inactive
@evantahler evantahler merged commit a5f1366 into master May 18, 2022
@evantahler evantahler deleted the evantahler-patch-1 branch May 18, 2022 23:59
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request May 20, 2022
Merged
suhomud pushed a commit that referenced this pull request May 23, 2022
@evantahler @octavia-squidington-iii @suhomud
Quote and comma-separate Pokemon examples to clarify help text (#12942)
af5cf8a 
* Quote and comma-separate Pokemon examples to clarify help text

Closes #12792

* Bump version

* auto-bump connector version

Co-authored-by: Octavia Squidington III <[email protected]>
@swyxio swyxio mentioned this pull request Jun 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroslopez pedroslopez pedroslopez approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Help text for connector input should be more clear about accepting one or multiple values
3 participants
@evantahler @pedroslopez @octavia-squidington-iii