[pokeapi connector] tweak suggested examples #12849
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokeapi connector only accepts 1 pokemon, not a comma separated list, this examples string gives the wrong expectation
swyxio
commented
May 13, 2022
| @@ -12,7 +12,7 @@ | |||
| "title": "Pokemon Name", | |||
| "description": "Pokemon requested from the API.", | |||
| "pattern": "^[a-z0-9_\\-]+$", | |||
| "examples": ["ditto, luxray, snorlax"] | |||
| "examples": ["pikachu"] | |||
There was a problem hiding this comment.
just went for the more famous pokemon name 🤷
|
fixed by #12942 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Describe what the change is solving
pokeapi connector only accepts 1 pokemon, not a comma separated list, this examples string gives the wrong expectation
It helps to add screenshots if it affects the frontend.
User confusion in airbyte internal slack: https://airbytehq-team.slack.com/archives/C0372JHKC2D/p1652303028586519
How
Describe the solution
just reduce the examples for now since its an easy fix.
ideally the more permanent fix in our UI is to distinguish between what's a valid example (which can be an array), and what is valid placeholder text (which here can only be a single value)