Display additional failure information when sync is expanded and jump to relevant log line #12896
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| import dayjs from "dayjs"; | ||
| import { useIntl } from "react-intl"; | ||
| import styled from "styled-components"; | ||
|
|
||
| import { AttemptRead } from "core/request/AirbyteClient"; | ||
|
|
||
| type IProps = { | ||
| attempts?: AttemptRead[]; | ||
| }; | ||
|
|
||
| const ExpandedFailureContainer = styled.div` | ||
| font-size: 12px; | ||
| line-height: 15px; | ||
| padding: 10px; | ||
| padding-left: 40px; | ||
| color: ${({ theme }) => theme.greyColor40}; | ||
| `; | ||
|
|
||
| const FailureDateDisplay = styled.span` | ||
| font-style: italic; | ||
| `; | ||
|
|
||
| const getFailureFromAttempt = (attempt: AttemptRead) => { | ||
| return attempt.failureSummary?.failures[0]; | ||
| }; | ||
|
|
||
| const ErrorDetails: React.FC<IProps> = ({ attempts }) => { | ||
| const { formatMessage } = useIntl(); | ||
|
|
||
| if (!attempts?.length) { | ||
| return null; | ||
| } | ||
|
|
||
| const getInternalFailureMessage = (attempt: AttemptRead) => { | ||
| const failure = getFailureFromAttempt(attempt); | ||
| const failureMessage = failure?.internalMessage ?? formatMessage({ id: "errorView.unknown" }); | ||
|
|
||
| return `${formatMessage({ | ||
| id: "sources.additionalFailureInfo", | ||
| })}: ${failureMessage}`; | ||
| }; | ||
|
|
||
| const attempt = attempts[attempts.length - 1]; | ||
| const failure = getFailureFromAttempt(attempt); | ||
|
|
||
| if (!failure) { | ||
| return null; | ||
| } | ||
|
|
||
| const internalMessage = getInternalFailureMessage(attempt); | ||
| return ( | ||
| <ExpandedFailureContainer> | ||
| {!!failure.timestamp && ( | ||
| <FailureDateDisplay>{dayjs.utc(failure.timestamp).format("YYYY-MM-DD HH:mm:ss")} - </FailureDateDisplay> | ||
| )} | ||
| {internalMessage} | ||
| </ExpandedFailureContainer> | ||
| ); | ||
| }; | ||
|
|
||
| export default ErrorDetails; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| import { FormattedMessage } from "react-intl"; | ||
| import { LazyLog } from "react-lazylog"; | ||
| import styled from "styled-components"; | ||
|
|
@@ -47,8 +46,10 @@ const Logs: React.FC<LogsProps> = ({ logsArray }) => { | |
| lineClassName="logLine" | ||
| highlightLineClassName="highlightLogLine" | ||
| selectableLines | ||
| follow={true} | ||
| style={{ background: "transparent" }} | ||
| scrollToLine={undefined} | ||
| highlight={[]} | ||
|
Comment on lines
+51
to
+52
There was a problem hiding this comment. Is this a hack to prevent it from scrolling to a specific line? There was a problem hiding this comment. yep - and it was undocumented and super hard to find. That's why I left this in so we would remember this for the future when we get to #12128 |
||
| /> | ||
| ) : ( | ||
| <FormattedMessage id="sources.emptyLogs" /> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| // This file should contain all stateful modification that need to be made to libraries. | ||
| // In general this is a bad pattern that should try to be avoided, but some libraries will | ||
| // require plugins to be registered to their global instance. This file encapsulates all those | ||
| // stateful modifications. | ||
|
|
||
| import dayjs from "dayjs"; | ||
| import customParseFormat from "dayjs/plugin/customParseFormat"; | ||
| import utc from "dayjs/plugin/utc"; | ||
|
|
||
| // Configure dayjs instance | ||
| dayjs.extend(customParseFormat); | ||
| dayjs.extend(utc); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we prefer it without the
={true}