Display additional failure information when sync is expanded and jump to relevant log line #12896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api
evantahler
changed the title
4 tasks
sherifnada
reviewed
May 17, 2022
timroes
reviewed
May 17, 2022
airbyte-webapp/src/components/JobItem/components/FailureDetails.tsx
Outdated
Show resolved
Hide resolved
evantahler
force-pushed
the
evan/display-failure-details
branch
from
0f7d1f3
to
d379334
Compare
evantahler
force-pushed
the
evan/display-failure-details
branch
from
d379334
to
a807c0a
Compare
evantahler
changed the title
Co-authored-by: Tim Roes <[email protected]>
Co-authored-by: Tim Roes <[email protected]>
Co-authored-by: Tim Roes <[email protected]>
Co-authored-by: Tim Roes <[email protected]>
evantahler
force-pushed
the
evan/display-failure-details
branch
from
cc49aa3
to
27efa7b
Compare
|
ok @timroes we are now just showing the (properly formatted) failure timestamp and not scrolling. I think this is ready to merge.
|
edmundito
approved these changes
May 26, 2022
Comment on lines
+51
to
+52
| scrollToLine={undefined} | ||
| highlight={[]} |
There was a problem hiding this comment.
Is this a hack to prevent it from scrolling to a specific line?
There was a problem hiding this comment.
yep - and it was undocumented and super hard to find. That's why I left this in so we would remember this for the future when we get to #12128
| @@ -47,8 +46,10 @@ const Logs: React.FC<LogsProps> = ({ logsArray }) => { | |||
| lineClassName="logLine" | |||
| highlightLineClassName="highlightLogLine" | |||
| selectableLines | |||
| follow | |||
| follow={true} | |||
There was a problem hiding this comment.
Actually, we prefer it without the ={true}
|
Fun fact - I had to retry this flaky test 5x before it passed https://github.com/airbytehq/airbyte/actions/runs/2392338287 |
jscottpolevault
pushed a commit
to jscottpolevault/airbyte
that referenced
this pull request
Jun 1, 2022
… to relevant log line (airbytehq#12896) * Display addtional failure information when sync is expanded * rename * Update airbyte-webapp/src/components/JobItem/components/FailureDetails.tsx Co-authored-by: Tim Roes <[email protected]> * fix bad merge * jump to timestamp * cleat timestamp when logs colapsed * speed up search * rename * Do what @pedroslopez says * Rebase from master after big API update * `floor` matchtimes for greater range matching * Update airbyte-webapp/src/components/JobItem/components/ErrorDetails.tsx Co-authored-by: Tim Roes <[email protected]> * Update airbyte-webapp/src/components/JobItem/components/ErrorDetails.tsx Co-authored-by: Tim Roes <[email protected]> * Update airbyte-webapp/src/components/JobItem/components/Logs.tsx Co-authored-by: Tim Roes <[email protected]> * Update airbyte-webapp/src/components/JobItem/JobItem.tsx Co-authored-by: Tim Roes <[email protected]> * replace regexp with `dayJs` * Extract dayjs into globals module * mach time in full-second resolution * revert `dayJs` and use `Date.parse` * Just show failure timestamp rather than scroll Co-authored-by: Tim Roes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When viewing your list of syncs, if there is an
internalMessageon the failure, this PR will display that message to the user when the sync is expanded:If there is a timestamp for that failure reason, you can now also choose to jump to the first line in the logs that matches that timestamp.
Screen.Recording.2022-05-18.at.2.21.49.PM.mov
As the platform gets better at tracking errors (e.g. #12423, there will be both a user-facing "externalMessage" and more detailed "internalMessage") about each failure. This PR displays both to the user.
Alternatives considered:
Closes #12628 and #12130