Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade ElasticSearch batch size from 256mib to 32mib #11752

Merged
merged 4 commits into from
May 30, 2022
Merged

Downgrade ElasticSearch batch size from 256mib to 32mib #11752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3cc9aef
Update ElasticsearchAirbyteMessageConsumerFactory.java
imiskolee Apr 6, 2022
26d6afb
Merge branch 'downgrade-es-max-size' of github.com:imiskolee/airbyte …
marcosmarxm Apr 19, 2022
9bbf970
add changleog and bump connector version seed file
marcosmarxm Apr 19, 2022
5c4d557
Merge branch 'master' into marcos/test-pr-11752
marcosmarxm Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/destination_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
- destinationDefinitionId: 68f351a7-2745-4bef-ad7f-996b8e51bb8c
name: ElasticSearch
dockerRepository: airbyte/destination-elasticsearch
dockerImageTag: 0.1.1
dockerImageTag: 0.1.2
documentationUrl: https://docs.airbyte.io/integrations/destinations/elasticsearch
icon: elasticsearch.svg
- name: Google Cloud Storage (GCS)
Expand Down
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/destination_specs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1202,7 +1202,7 @@
supported_destination_sync_modes:
- "overwrite"
- "append"
- dockerImage: "airbyte/destination-elasticsearch:0.1.1"
- dockerImage: "airbyte/destination-elasticsearch:0.1.2"
spec:
documentationUrl: "https://docs.airbyte.io/integrations/destinations/elasticsearch"
connectionSpecification:
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/destination-elasticsearch/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ ENV APPLICATION destination-elasticsearch

COPY --from=build /airbyte /airbyte

LABEL io.airbyte.version=0.1.1
LABEL io.airbyte.version=0.1.2
LABEL io.airbyte.name=airbyte/destination-elasticsearch
2 changes: 1 addition & 1 deletion ...te/integrations/destination/elasticsearch/ElasticsearchAirbyteMessageConsumerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
public class ElasticsearchAirbyteMessageConsumerFactory {

private static final Logger log = LoggerFactory.getLogger(ElasticsearchAirbyteMessageConsumerFactory.class);
private static final int MAX_BATCH_SIZE_BYTES = 1024 * 1024 * 1024 / 4; // 256mib
private static final int MAX_BATCH_SIZE_BYTES = 1024 * 1024 * 32; // 32mib
private static final ObjectMapper mapper = new ObjectMapper();

private static final AtomicLong recordsWritten = new AtomicLong(0);
Expand Down
9 changes: 8 additions & 1 deletion docs/integrations/destinations/elasticsearch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,11 @@ The connector should be enhanced to support variable batch sizes.
### Setup guide

Enter the hostname and/or other configuration information ...
#### TODO: more info, screenshots?, etc...
## CHANGELOG

| Version | Date | Pull Request | Subject |
| :--- | :--- | :--- | :--- |
| 0.1.2 | 2022-04-19 | [11752](https://github.com/airbytehq/airbyte/pull/11752) | Reduce batch size to 32Mb |
| 0.1.1 | 2022-02-10 | [10256](https://github.com/airbytehq/airbyte/pull/1256) | Add ExitOnOutOfMemoryError connectors |
| 0.1.0 | 2021-10-13 | [7005](https://github.com/airbytehq/airbyte/pull/7005) | Initial release. |