Downgrade ElasticSearch batch size from 256mib to 32mib #11752

imiskolee · 2022-04-06T09:35:30Z

What

downgrade elasticsearch max length for small elastic search server. 256mb it's too high.

How

downgrade to 32mb

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

CLAassistant · 2022-04-06T09:35:42Z

All committers have signed the CLA.

marcosmarxm · 2022-04-06T18:55:31Z

can you sign the CLA @imiskolee ?

imiskolee · 2022-04-07T09:19:18Z

can you sign the CLA @imiskolee ?

already signed.

imiskolee · 2022-04-08T02:43:14Z

@marcosmarxm hi, we're blocked on this issue now, can someone check it.

marcosmarxm · 2022-04-08T19:54:13Z

@imiskolee this reduce the buffer size when reading messages from ElasticSearch. How does it impacts in your ElasticSearch server? Did you run test locally, build dev and test if works?

imiskolee · 2022-04-09T03:42:50Z

@imiskolee this reduce the buffer size when reading messages from ElasticSearch. How does it impacts in your ElasticSearch server? Did you run test locally, build dev and test if works?

yes, I tested small table around 32mib,it's successful, and elastic search commtinuy also said payload keeping small is better.

marcosmarxm · 2022-04-19T18:41:02Z

/test connector=connectors/destination-elasticsearch

🕑 connectors/destination-elasticsearch https://github.com/airbytehq/airbyte/actions/runs/2191529284
✅ connectors/destination-elasticsearch https://github.com/airbytehq/airbyte/actions/runs/2191529284
No Python unittests run

…into marcos/test-pr-11752

marcosmarxm · 2022-04-19T21:23:09Z

/publish connector=connectors/destination-elasticsearch auto-bump-version=false

🕑 connectors/destination-elasticsearch https://github.com/airbytehq/airbyte/actions/runs/2192260078
❌ Failed to publish connectors/destination-elasticsearch

marcosmarxm · 2022-04-19T23:42:40Z

/publish connector=connectors/destination-elasticsearch auto-bump-version=false

🕑 connectors/destination-elasticsearch https://github.com/airbytehq/airbyte/actions/runs/2192774485
❌ Failed to publish connectors/destination-elasticsearch

marcosmarxm · 2022-04-20T22:29:36Z

@imiskolee I'm having problems with our CI, I'll check what is causing the issues and publish your contribution

marcosmarxm · 2022-05-30T13:07:35Z

/publish connector=connectors/destination-elasticsearch run-tests=false auto-bump-version=false

🕑 connectors/destination-elasticsearch https://github.com/airbytehq/airbyte/actions/runs/2409241653
🚀 Successfully published connectors/destination-elasticsearch
✅ connectors/destination-elasticsearch https://github.com/airbytehq/airbyte/actions/runs/2409241653

) * Update ElasticsearchAirbyteMessageConsumerFactory.java * add changleog and bump connector version seed file Co-authored-by: marcosmarxm <[email protected]>

Update ElasticsearchAirbyteMessageConsumerFactory.java

3cc9aef

imiskolee mentioned this pull request Apr 6, 2022

Can not sync large table to elasticsearch #11749

Closed

github-actions bot added the area/connectors Connector related issues label Apr 6, 2022

octavia-squidington-iii added the community label Apr 6, 2022

imiskolee changed the title ~~Update ElasticsearchAirbyteMessageConsumerFactory.java~~ Downgrade ElasticSearch batch size from 256mib to 32mib Apr 7, 2022

marcosmarxm self-assigned this Apr 13, 2022

marcosmarxm added 2 commits April 19, 2022 18:15

Merge branch 'downgrade-es-max-size' of github.com:imiskolee/airbyte …

26d6afb

…into marcos/test-pr-11752

add changleog and bump connector version seed file

9bbf970

imiskolee requested a review from a team as a code owner April 19, 2022 21:21

marcosmarxm removed the request for review from a team April 19, 2022 21:21

Merge branch 'master' into marcos/test-pr-11752

5c4d557

github-actions bot removed area/worker Related to worker kubernetes labels Apr 19, 2022

github-actions bot removed area/frontend area/api Related to the api area/scheduler CDK Connector Development Kit normalization area/server area/platform issues related to the platform labels Apr 19, 2022

marcosmarxm approved these changes May 30, 2022

View reviewed changes

marcosmarxm merged commit 721b5b6 into airbytehq:master May 30, 2022

octavia-squidington-iii mentioned this pull request May 31, 2022

Bump Airbyte version from 0.39.5-alpha to 0.39.6-alpha #13350

Merged

imiskolee deleted the downgrade-es-max-size branch June 2, 2022 05:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Downgrade ElasticSearch batch size from 256mib to 32mib #11752

Downgrade ElasticSearch batch size from 256mib to 32mib #11752

imiskolee commented Apr 6, 2022

CLAassistant commented Apr 6, 2022 •

edited

Loading

marcosmarxm commented Apr 6, 2022

imiskolee commented Apr 7, 2022

imiskolee commented Apr 8, 2022

marcosmarxm commented Apr 8, 2022

imiskolee commented Apr 9, 2022

marcosmarxm commented Apr 19, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Apr 19, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Apr 19, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Apr 20, 2022

marcosmarxm commented May 30, 2022 •

edited by github-actions bot

Loading

Downgrade ElasticSearch batch size from 256mib to 32mib #11752

Downgrade ElasticSearch batch size from 256mib to 32mib #11752

Conversation

imiskolee commented Apr 6, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

CLAassistant commented Apr 6, 2022 • edited Loading

marcosmarxm commented Apr 6, 2022

imiskolee commented Apr 7, 2022

imiskolee commented Apr 8, 2022

marcosmarxm commented Apr 8, 2022

imiskolee commented Apr 9, 2022

marcosmarxm commented Apr 19, 2022 • edited by github-actions bot Loading

marcosmarxm commented Apr 19, 2022 • edited by github-actions bot Loading

marcosmarxm commented Apr 19, 2022 • edited by github-actions bot Loading

marcosmarxm commented Apr 20, 2022

marcosmarxm commented May 30, 2022 • edited by github-actions bot Loading

CLAassistant commented Apr 6, 2022 •

edited

Loading

marcosmarxm commented Apr 19, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Apr 19, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Apr 19, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented May 30, 2022 •

edited by github-actions bot

Loading