Fix issue where LottieLogger.shared.assertionFailure would unexpectedly crash in release builds
#1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly crash in release builds
erichoracek
added a commit
to airbnb/epoxy-ios
that referenced
this pull request
Jul 27, 2022
…se builds In the same style as airbnb/lottie-ios#1665, fixes issue where `EpoxyLogger.shared.assertionFailure` and `EpoxyLogger.shared.assertionFailure` and `EpoxyLogger.shared.assert` would unexpectedly crash in release builds.
erichoracek
added a commit
to airbnb/epoxy-ios
that referenced
this pull request
Jul 27, 2022
…se builds In the same style as airbnb/lottie-ios#1665, fixes an issue where `EpoxyLogger.shared.assertionFailure` and `EpoxyLogger.shared.assert` would unexpectedly crash in release builds.
Merged
3 tasks
erichoracek
added a commit
to airbnb/epoxy-ios
that referenced
this pull request
Jul 27, 2022
…se builds (#115) In the same style as airbnb/lottie-ios#1665, fixes an issue where `EpoxyLogger.shared.assertionFailure` and `EpoxyLogger.shared.assert` would unexpectedly crash in release builds.
renabriseno68
added a commit
to renabriseno68/epoxy-ios-flutter-developer
that referenced
this pull request
Sep 13, 2022
…se builds (#115) In the same style as airbnb/lottie-ios#1665, fixes an issue where `EpoxyLogger.shared.assertionFailure` and `EpoxyLogger.shared.assert` would unexpectedly crash in release builds.
calda
added a commit
that referenced
this pull request
Nov 28, 2022
…ly crash in release builds (#1665)
calda
added a commit
that referenced
this pull request
Dec 1, 2022
…ly crash in release builds (#1665)
MoroziOS
pushed a commit
to MoroziOS/tmg-lottie-ios
that referenced
this pull request
May 22, 2024
…ly crash in release builds (airbnb#1665)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue where
LottieLogger.shared.assertionFailurewould unexpectedly crash in release builds.Naively I would expect both of these implementations to behave the same. I filed a compiler bug for this: swiftlang/swift#60249
Fixes #1663.