Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where EpoxyLogger asserts would unexpectedly crash in release builds #115

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

erichoracek
Copy link
Collaborator

Change summary

In the same style as airbnb/lottie-ios#1665, fixes an issue where EpoxyLogger.shared.assertionFailure and EpoxyLogger.shared.assert would unexpectedly crash in release builds.

How was it tested?

How did you verify that this change accomplished what you expected? Add more detail as needed.

  • Tested by Cal on Lottie

Pull request checklist

All items in this checklist must be completed before a pull request will be reviewed.

  • Risky changes have been put behind a feature flag, e.g. CollectionViewConfiguration
  • Added a CHANGELOG.md entry in the "Unreleased" section for any library changes

…se builds

In the same style as airbnb/lottie-ios#1665, fixes an issue where `EpoxyLogger.shared.assertionFailure` and `EpoxyLogger.shared.assert` would unexpectedly crash in release builds.
@erichoracek erichoracek marked this pull request as ready for review July 27, 2022 16:29
@erichoracek erichoracek enabled auto-merge (squash) July 27, 2022 16:54
@erichoracek erichoracek merged commit 8fcef3b into master Jul 27, 2022
@erichoracek erichoracek deleted the eh--fix-assertion-failure branch July 27, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants