Poor performance (drop frame) during scrolling when animation is loop #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test ok |
|
Hi @liwenfei1991, looks like the tests for this change are passing. Could you rebase to resolve the merge conflict? Then I think we can merge this. |
* 'master' of https://github.com/liwenfei1991/lottie-ios: Poor performance (drop frame) during scrolling when animation is loop # Conflicts: # Sources/Private/LayerContainers/Utility/InvertedMatteLayer.swift
|
Hi, i have rebased my code, hope you can merge my code to fix this issue,
thank you!
Cal Stephens ***@***.***> 于2022年5月16日周一 22:08写道：
… Hi @liwenfei1991 <https://github.com/liwenfei1991>, looks like the tests
for this change are passing. Could you rebase to resolve the merge
conflict? Then I think we can merge this.
—
Reply to this email directly, view it on GitHub
<#1388 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASJABE7AJWERLTNFWZ2F3PDVKJJFBANCNFSM5C5E3P4A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thanks! |
calda
approved these changes
May 16, 2022
|
@liwenfei1991 FYI, we had to revert this change due to #1683. |
calda
pushed a commit
that referenced
this pull request
Nov 28, 2022
calda
pushed a commit
that referenced
this pull request
Dec 1, 2022
MoroziOS
pushed a commit
to MoroziOS/tmg-lottie-ios
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let animation = Animation.named("XXX")
let animationView = AnimationView()
animationView.animation = animation
animationView.loopMode = .loop
animationView.backgroundBehavior = .pauseAndRestore
animationView.play()
insert the animationView into an UITableViewCell, when scrolling , the fps is about 40, the json file is below attach files
bojin1.json.zip