Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation using inverted matte layer are suffering frame drops in 3.4.0 #1683

Closed
kirti-swiggy opened this issue Jul 31, 2022 · 2 comments · Fixed by #1684
Closed

Animation using inverted matte layer are suffering frame drops in 3.4.0 #1683

kirti-swiggy opened this issue Jul 31, 2022 · 2 comments · Fixed by #1684
Labels

Comments

@kirti-swiggy
Copy link
Contributor

kirti-swiggy commented Jul 31, 2022

In lottie version 3.4.0 (and 3.4.1), frames are dropping for animations using inverted matte layer.

I dug deep into the problem. Found out that #1388 is the cause. After reverting this change, animation seems to work fine.

Which Version of Lottie are you using?

Lottie 3.4.0

Expected Behavior

Simulator.Screen.Recording.-.iPhone.13.Pro.-.2022-07-31.at.17.27.18.mp4

Actual Behavior

Animation doesn't play.

Animation JSON

lf20_eLe0Jq.json.zip

Sample project

TestLottie.zip

@calda calda added the bug label Jul 31, 2022
@calda
Copy link
Member

calda commented Jul 31, 2022

Thanks for digging in and finding the change that caused this regression! I'll revert that change and add your sample animation to the regression suite.

@calda
Copy link
Member

calda commented Jul 31, 2022

Fixed in #1684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants