The imports in tests for the rule import/no-extraneous-dependencies

[Alex1990]

Some of the dependencies in test code are in devDependencies. When I lint the test code, some errors appear:

  1:1  error  'chai' should be listed in the project's dependencies, not devDependencies  import/no-extraneous-dependencies

This error is unexpected.

[ljharb]

@Alex1990 the default is for the entire project, which is to only allow dependencies. The proper solution is to make a .eslintrc in your "test" folder, that overrides the rule to allow devDependencies also.

[Alex1990]

Okay, so I must create two .eslintrc files.

[ljharb]

Yep! You probably already need one for your tests anyways, to enable the mocha env, or to allow for more nested callbacks than in your production code, etc :-)

[benoitgrelard]

Hi @ljharb, I was surprised by this too. I understand what you mean and it makes sense if you have a separate test folder with all your tests in it. However, in our situation we have interleaved source and test files. I guess that would be impossible until we get eslint/eslint#3611 with eslint?

So am I correct in thinking that the way forward for us is to override the rule to allow devDependencies?

[ljharb]

@artisologic unfortunately, that approach (interleaved source/test files) is incompatible with a great many tools. Indeed, until eslint/eslint#3611 is done, it's simply not practical to use eslint and also use that approach - so I'd recommend avoiding that approach until all of the tools you use support a glob-style configuration.

If you persist in interleaving tests and source, no matter how you configure this rule, you'll lose out on the most important benefit - ensuring that everything your source requires is explicitly listed as a dependency.

[knpwrs]

Worth noting, with the latest published version of eslint-plugin-import you can use globs to configure the no-extraneous-dependencies rule: import-js/eslint-plugin-import#527

[ljharb]

Yes, take a look at who filed the issue requesting it :-p import-js/eslint-plugin-import#470

This will be released as an update soon.

[SimenB]

@ljharb It's been released a while now, are you going to update the default here (I can provide a PR for it)?

EDIT: nvm, just took a couple of mins: #1131

[ljharb]

@SimenB I'm waiting on import-js/eslint-plugin-import#602 / import-js/eslint-plugin-import#630, otherwise the globs have to be too accepting.

[ljharb]

eslint-config-airbnb v13.0.0 is now released.