-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup test for client and add tests #69
Merged
Shalinit3
merged 3 commits into
pesto-students:master
from
Shalinit3:feature/client-test
Mar 22, 2019
Merged
Setup test for client and add tests #69
Shalinit3
merged 3 commits into
pesto-students:master
from
Shalinit3:feature/client-test
Mar 22, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shalinit3
changed the title
Setup test for client and add test for ScoreCard component
Setup test for client and add tests
Mar 20, 2019
Shalinit3
force-pushed
the
feature/client-test
branch
2 times, most recently
from
March 20, 2019 17:39
771c981
to
54ec8b6
Compare
Shalinit3
force-pushed
the
feature/client-test
branch
from
March 20, 2019 17:42
54ec8b6
to
1db9732
Compare
hassan23
previously requested changes
Mar 21, 2019
nimish-gupta
previously requested changes
Mar 22, 2019
Shalinit3
force-pushed
the
feature/client-test
branch
from
March 22, 2019 17:10
1db9732
to
79d5544
Compare
Shalinit3
dismissed
hassan23’s stale review
March 22, 2019 17:51
Navbar test cases will be changed when someone will work on the same.
shivangg
previously requested changes
Mar 22, 2019
318097
approved these changes
Mar 22, 2019
Shalinit3
force-pushed
the
feature/client-test
branch
from
March 22, 2019 19:20
df9f603
to
0f176b5
Compare
Code Climate has analyzed commit 0f176b5 and detected 0 issues on this pull request. View more on Code Climate. |
Shalinit3
dismissed stale reviews from shivangg and nimish-gupta
March 22, 2019 19:25
Done the requested changes
shivangg
suggested changes
Mar 22, 2019
nimish-gupta
approved these changes
Mar 22, 2019
shivangg
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will setup enzyme for client side.
Will add test cases for basic components.
Note: Test cases for Navbar are what I found relevant for now. They are to be updated.
resolves: #48