Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup test for client and add tests #69

Merged
merged 3 commits into from
Mar 22, 2019

Conversation

Shalinit3
Copy link
Contributor

@Shalinit3 Shalinit3 commented Mar 20, 2019

Will setup enzyme for client side.
Will add test cases for basic components.

Note: Test cases for Navbar are what I found relevant for now. They are to be updated.
resolves: #48

@Shalinit3 Shalinit3 changed the title Setup test for client and add test for ScoreCard component Setup test for client and add tests Mar 20, 2019
@Shalinit3 Shalinit3 force-pushed the feature/client-test branch 2 times, most recently from 771c981 to 54ec8b6 Compare March 20, 2019 17:39
@Shalinit3 Shalinit3 marked this pull request as ready for review March 20, 2019 17:40
@Shalinit3 Shalinit3 force-pushed the feature/client-test branch from 54ec8b6 to 1db9732 Compare March 20, 2019 17:42
@Shalinit3 Shalinit3 requested a review from shivangg March 20, 2019 17:43
@Shalinit3 Shalinit3 requested a review from hassan23 March 22, 2019 04:56
@Shalinit3 Shalinit3 force-pushed the feature/client-test branch from 1db9732 to 79d5544 Compare March 22, 2019 17:10
@Shalinit3 Shalinit3 requested a review from nimish-gupta March 22, 2019 17:12
@Shalinit3 Shalinit3 dismissed hassan23’s stale review March 22, 2019 17:51

Navbar test cases will be changed when someone will work on the same.

.eslintrc Show resolved Hide resolved
client/src/components/UI/__tests__/navBar.test.js Outdated Show resolved Hide resolved
client/src/components/UI/__tests__/scoreCard.test.js Outdated Show resolved Hide resolved
@Shalinit3 Shalinit3 force-pushed the feature/client-test branch from df9f603 to 0f176b5 Compare March 22, 2019 19:20
@codeclimate
Copy link

codeclimate bot commented Mar 22, 2019

Code Climate has analyzed commit 0f176b5 and detected 0 issues on this pull request.

View more on Code Climate.

@Shalinit3 Shalinit3 requested a review from shivangg March 22, 2019 19:22
@Shalinit3 Shalinit3 dismissed stale reviews from shivangg and nimish-gupta March 22, 2019 19:25

Done the requested changes

.eslintrc Show resolved Hide resolved
@Shalinit3 Shalinit3 requested a review from shivangg March 22, 2019 20:22
@Shalinit3 Shalinit3 merged commit 2cff5dc into pesto-students:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create test cases for the components
5 participants