Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9659/1bb146a backport][3.11] Refactor FlowControlDataQueue to improve performances #9665

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 4, 2024

(cherry picked from commit 1bb146a)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 4, 2024
@bdraco bdraco changed the title Refactor FlowControlDataQueue to improve performances (#9659) [PR #9659/1bb146a backport][3.11] Refactor FlowControlDataQueue to improve performances Nov 4, 2024
Copy link

codspeed-hq bot commented Nov 4, 2024

CodSpeed Performance Report

Merging #9665 will improve performances by 11.85%

Comparing patchback/backports/3.11/1bb146ad36b1660548d23166be2e7b37579a1001/pr-9659 (8425232) with 3.11 (8f6d7b5)

Summary

⚡ 2 improvements
✅ 11 untouched benchmarks

Benchmarks breakdown

Benchmark 3.11 patchback/backports/3.11/1bb146ad36b1660548d23166be2e7b37579a1001/pr-9659 Change
test_one_thousand_round_trip_websocket_binary_messages[pyloop] 20.5 ms 18.3 ms +11.52%
test_one_thousand_round_trip_websocket_text_messages[pyloop] 21 ms 18.8 ms +11.85%

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.89%. Comparing base (8f6d7b5) to head (8425232).
Report is 1 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11    #9665   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files         117      117           
  Lines       35550    35559    +9     
  Branches     4261     4264    +3     
=======================================
+ Hits        34802    34811    +9     
  Misses        559      559           
  Partials      189      189           
Flag Coverage Δ
CI-GHA 97.78% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.47% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.37% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.68% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.54% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 96.97% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 97.04% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 96.62% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 97.51% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 97.49% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.46% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 96.89% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.49% <100.00%> (+<0.01%) ⬆️
VM-macos 96.68% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.47% <100.00%> (+<0.01%) ⬆️
VM-windows 94.37% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review November 4, 2024 03:07
@bdraco bdraco enabled auto-merge (squash) November 4, 2024 03:07
@bdraco bdraco merged commit aa42f60 into 3.11 Nov 4, 2024
35 of 36 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/1bb146ad36b1660548d23166be2e7b37579a1001/pr-9659 branch November 4, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant