Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backwards compatibility with ssl #8098

Merged
merged 6 commits into from
Jan 29, 2024
Merged

Conversation

Dreamsorcerer
Copy link
Member

Fixes #8097.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b58e503) 97.31% compared to head (5a2d448) 97.31%.
Report is 1 commits behind head on 3.10.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #8098   +/-   ##
=======================================
  Coverage   97.31%   97.31%           
=======================================
  Files         108      108           
  Lines       32932    32937    +5     
  Branches     3926     3927    +1     
=======================================
+ Hits        32049    32054    +5     
  Misses        674      674           
  Partials      209      209           
Flag Coverage Δ
CI-GHA 97.23% <100.00%> (+<0.01%) ⬆️
OS-Linux 96.92% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.45% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.74% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 94.35% <100.00%> (+<0.01%) ⬆️
Py-3.10.13 96.70% <100.00%> (+<0.01%) ⬆️
Py-3.11.7 96.41% <100.00%> (+<0.01%) ⬆️
Py-3.12.1 96.37% <100.00%> (?)
Py-3.8.10 94.33% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.63% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 94.34% <100.00%> (+<0.01%) ⬆️
Py-3.9.18 96.69% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.15 96.23% <100.00%> (+<0.01%) ⬆️
VM-macos 96.74% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 96.92% <100.00%> (+<0.01%) ⬆️
VM-windows 94.45% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGES/8098.bugfix.rst Outdated Show resolved Hide resolved
CHANGES/8098.bugfix.rst Outdated Show resolved Hide resolved
Dreamsorcerer and others added 2 commits January 29, 2024 15:52
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
CHANGES/8098.bugfix.rst Outdated Show resolved Hide resolved
@Dreamsorcerer Dreamsorcerer merged commit aca206f into 3.10 Jan 29, 2024
28 of 31 checks passed
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-8 branch January 29, 2024 17:29
Copy link
Contributor

patchback bot commented Jan 29, 2024

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/aca206fc27ecec4e0dc14de6ab11816e7f35409c/pr-8098

Backported as #8101

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 29, 2024
Fixes #8097.

---------

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
(cherry picked from commit aca206f)
Dreamsorcerer added a commit that referenced this pull request Jan 29, 2024
#8101)

**This is a backport of PR #8098 as merged into 3.10
(aca206f).**

Fixes #8097.

Co-authored-by: Sam Bull <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants