Address breaking change introduced in aiohttp==3.9.2

[jakob-keller]

Description of Change

aiohttp==3.9.2 introduces a change in handling SSL/TLS-related arguments that breaks our code. This PR applies current aiohttp best-practices to SSL/TLS-related arguments.

Assumptions

• The PR is based on Fix use of HTTPS proxies #1070 #1077 which fixes HTTPS proxy support and is thus related.
• The dependency specification for aiohttp was bumped to prevent regressions with our updated code and aiohttp<3.9.2.

Checklist for All Submissions

• I have added change info to CHANGES.rst
• If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details): closes potential aiohttp>=4.0.0 breaking changes #882
  • Detailed description of issue
  • Alternative methods considered (if any)
  • How issue is being resolved
  • How issue can be reproduced
• If this is providing a new feature (can be provided via link to issue with these details):
  • Detailed description of new feature
  • Why needed
  • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

• I have read and followed CONTRIBUTING.rst
• I have updated test_patches.py where/if appropriate (also check if no changes necessary)
• I have ensured that the awscli/boto3 versions match the updated botocore version

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.28%. Comparing base (2d6520b) to head (05c9321).
Report is 71 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1081      +/-   ##
==========================================
- Coverage   86.33%   86.28%   -0.06%     
==========================================
  Files          62       62              
  Lines        5913     5913              
==========================================
- Hits         5105     5102       -3     
- Misses        808      811       +3     

Flag	Coverage Δ
unittests	86.28% <100.00%> (-0.06%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dacevedo12]

Seems like they addressed this in 3.9.3 aio-libs/aiohttp#8098

[jakob-keller]

Seems like they addressed this in 3.9.3 aio-libs/aiohttp#8098

Indeed, still we should cease using the deprecated verify_ssl argument to prevent this issue from popping up again in the future.

[jakkdl]

Seems like they addressed this in 3.9.3 aio-libs/aiohttp#8098

Indeed, still we should cease using the deprecated verify_ssl argument to prevent this issue from popping up again in the future.

perhaps of note is that #749 (which I've been slowly chugging away on) wants to replace aiohttp with httpx, so there might not be a very long future for aiohttp.

[jakob-keller]

@thehesiod: This PR builds on #1077. Maybe we should first finish that PR?

[jakob-keller]

CI doesn't allow for two releases dated the same in CHANGES.txt :-(

[thehesiod]

will fix test here, one sec