Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #6401/5e0e6b70 backport][3.8] Edited the web.run_app declaration. #6404

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Dec 9, 2021

This is a backport of PR #6401 as merged into master (5e0e6b7).

The run_app function takes the "sock" parameter which
can be iterable as well.

What do these changes do?

Edited type annotation of the web.run_app function in according to its behavior.

Are there changes in behavior for the user?

This change will be helpful for people who use a type checker.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

* Edited the web.run_app declaration.

The run_app function takes the "sock" parameter which
can be iterable as well.

* Updated CONTRIBUTORS.txt.

* Added description to CHANGES.

* Use TypingIterable instead of Iterable.

(cherry picked from commit 5e0e6b7)
@patchback patchback bot requested review from asvetlov and webknjaz as code owners December 9, 2021 21:17
@patchback patchback bot mentioned this pull request Dec 9, 2021
5 tasks
@Dreamsorcerer Dreamsorcerer enabled auto-merge (squash) December 9, 2021 21:18
@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

❗ No coverage uploaded for pull request base (3.8@83e9b8a). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 5e0e6b7 differs from pull request most recent head 74749e7. Consider uploading reports for the commit 74749e7 to get more accurate results
Impacted file tree graph

@@          Coverage Diff           @@
##             3.8    #6404   +/-   ##
======================================
  Coverage       ?   93.34%           
======================================
  Files          ?      104           
  Lines          ?    30456           
  Branches       ?     3064           
======================================
  Hits           ?    28429           
  Misses         ?     1850           
  Partials       ?      177           
Flag Coverage Δ
unit 93.26% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83e9b8a...74749e7. Read the comment docs.

@asvetlov asvetlov disabled auto-merge December 13, 2021 18:44
@asvetlov asvetlov closed this Dec 13, 2021
@asvetlov asvetlov reopened this Dec 13, 2021
@asvetlov asvetlov merged commit 98ae7f3 into 3.8 Dec 14, 2021
@asvetlov asvetlov deleted the patchback/backports/3.8/5e0e6b7080f2408d5f1dd544c0e1cf88378b7b10/pr-6401 branch December 14, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants