Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edited the web.run_app declaration. #6401

Merged
merged 4 commits into from
Dec 9, 2021
Merged

Edited the web.run_app declaration. #6401

merged 4 commits into from
Dec 9, 2021

Conversation

TiunovNN
Copy link
Contributor

@TiunovNN TiunovNN commented Dec 8, 2021

The run_app function takes the "sock" parameter which
can be iterable as well.

What do these changes do?

Edited type annotation of the web.run_app function in according to its behavior.

Are there changes in behavior for the user?

This change will be helpful for people who use a type checker.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@TiunovNN
Edited the web.run_app declaration.
d630cde 
The run_app function takes the "sock" parameter which
can be iterable as well.
@TiunovNN TiunovNN requested a review from asvetlov as a code owner December 8, 2021 19:38
@TiunovNN TiunovNN requested a review from webknjaz as a code owner December 8, 2021 19:42
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Dec 8, 2021
asvetlov
asvetlov requested changes Dec 9, 2021
View reviewed changes
aiohttp/web.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 9, 2021 •
edited
Loading

Codecov Report

Merging #6401 (62913cd) into master (dcb44a9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6401   +/-   ##
=======================================
  Coverage   93.34%   93.34%           
=======================================
  Files         104      104           
  Lines       30456    30456           
  Branches     3064     3064           
=======================================
  Hits        28429    28429           
  Misses       1850     1850           
  Partials      177      177
Flag Coverage Δ
unit 93.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/web.py 99.15% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcb44a9...62913cd. Read the comment docs.

@Dreamsorcerer Dreamsorcerer merged commit 5e0e6b7 into aio-libs:master Dec 9, 2021
@patchback
Copy link
Contributor

patchback bot commented Dec 9, 2021 •
edited
Loading

Backport to 3.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.8/5e0e6b7080f2408d5f1dd544c0e1cf88378b7b10/pr-6401

Backported as #6404

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 9, 2021
@TiunovNN @patchback
Edited the web.run_app declaration. (#6401)
74749e7 
* Edited the web.run_app declaration.

The run_app function takes the "sock" parameter which
can be iterable as well.

* Updated CONTRIBUTORS.txt.

* Added description to CHANGES.

* Use TypingIterable instead of Iterable.

(cherry picked from commit 5e0e6b7)
@patchback patchback bot mentioned this pull request Dec 9, 2021
Merged
5 tasks
@patchback
Copy link
Contributor

patchback bot commented Dec 9, 2021 •
edited
Loading

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/5e0e6b7080f2408d5f1dd544c0e1cf88378b7b10/pr-6401

Backported as #6405

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 9, 2021
@TiunovNN @patchback
Edited the web.run_app declaration. (#6401)
54f9a8f 
* Edited the web.run_app declaration.

The run_app function takes the "sock" parameter which
can be iterable as well.

* Updated CONTRIBUTORS.txt.

* Added description to CHANGES.

* Use TypingIterable instead of Iterable.

(cherry picked from commit 5e0e6b7)
@patchback patchback bot mentioned this pull request Dec 9, 2021
Merged
5 tasks
Dreamsorcerer pushed a commit that referenced this pull request Dec 9, 2021
@patchback @TiunovNN
Edited the web.run_app declaration. (#6401) (#6405)
677eec9 
* Edited the web.run_app declaration.

The run_app function takes the "sock" parameter which
can be iterable as well.

* Updated CONTRIBUTORS.txt.

* Added description to CHANGES.

* Use TypingIterable instead of Iterable.

(cherry picked from commit 5e0e6b7)

Co-authored-by: TiunovNN <[email protected]>
asvetlov pushed a commit that referenced this pull request Dec 14, 2021
@patchback @TiunovNN
Edited the web.run_app declaration. (#6401) (#6404)
98ae7f3 
Co-authored-by: TiunovNN <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov requested changes

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TiunovNN @asvetlov @Dreamsorcerer