Fix #4097: misleading message in the string representation of ClientConnectorError
#4120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report
@@ Coverage Diff @@
## master #4120 +/- ##
==========================================
- Coverage 97.86% 97.81% -0.05%
==========================================
Files 43 43
Lines 8807 8807
Branches 1378 1378
==========================================
- Hits 8619 8615 -4
- Misses 75 78 +3
- Partials 113 114 +1
Continue to review full report at Codecov.
|
asvetlov
approved these changes
Oct 1, 2019
|
Thanks! |
asvetlov
pushed a commit
that referenced
this pull request
Oct 1, 2019
…onnectorError` (#4097) (#4120) (cherry picked from commit ac180b1) Co-authored-by: Bryan Kok <[email protected]>
asvetlov
added a commit
that referenced
this pull request
Oct 1, 2019
…onnectorError` (#4097) (#4120) (#4121) (cherry picked from commit ac180b1) Co-authored-by: Bryan Kok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Trivial change; according to https://docs.aiohttp.org/en/stable/client_advanced.html#ssl-control-for-tcp-sockets the
ssl=Falseargument is to disable the default behavior which is to throw exception if SSL verifcation fails such as with self-signed certificates, not for enabling or disabling SSLRelated issue number
#4097
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.