Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix connection info in ClientConnectorError client exception #4097

Closed
asvetlov opened this issue Sep 25, 2019 · 1 comment
Closed

Fix connection info in ClientConnectorError client exception #4097

asvetlov opened this issue Sep 25, 2019 · 1 comment
Labels
client enhancement good first issue Good for newcomers need pull request

Comments

@asvetlov
Copy link
Member

The message like Cannot connect to host www.google.com:443 ssl:None is misleading.
ssl:None means 'default', not 'disabled'

Cannot connect to host www.google.com:443 ssl:[default] looks much better
@asvetlov asvetlov added the good first issue Good for newcomers label Sep 25, 2019
Transfusion added a commit to Transfusion/aiohttp that referenced this issue Sep 30, 2019
@Transfusion
Fix misleading message in the string representation of `ClientConnect…
376a375 
…orError` (aio-libs#4097)
@Transfusion Transfusion mentioned this issue Sep 30, 2019
Merged
5 tasks
asvetlov pushed a commit that referenced this issue Oct 1, 2019
@Transfusion @asvetlov
Fix misleading message in the string representation of `ClientConnect…
ac180b1 
…orError` (#4097) (#4120)
asvetlov pushed a commit that referenced this issue Oct 1, 2019
@Transfusion @asvetlov
[3.6] Fix misleading message in the string representation of `ClientC…
0709178 
…onnectorError` (#4097) (#4120)

(cherry picked from commit ac180b1)

Co-authored-by: Bryan Kok <[email protected]>
@asvetlov
Copy link
Member Author

asvetlov commented Oct 1, 2019

Fixed by #4120

@asvetlov asvetlov closed this as completed Oct 1, 2019
asvetlov added a commit that referenced this issue Oct 1, 2019
@asvetlov @Transfusion
[3.6] Fix misleading message in the string representation of `ClientC…
780d5b4 
…onnectorError` (#4097) (#4120) (#4121)

(cherry picked from commit ac180b1)

Co-authored-by: Bryan Kok <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client enhancement good first issue Good for newcomers need pull request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asvetlov @webknjaz