Update docs to clarify proxy support #4101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify that, while aiohttp supports proxies that upgrade to HTTPS via CONNECT, it doesn't support proxies that must be connected to via `https://` - #4100 .
Record change
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report
@@ Coverage Diff @@
## master #4101 +/- ##
==========================================
- Coverage 97.86% 97.81% -0.05%
==========================================
Files 43 43
Lines 8807 8807
Branches 1378 1378
==========================================
- Hits 8619 8615 -4
- Misses 75 78 +3
- Partials 113 114 +1
Continue to review full report at Codecov.
|
asvetlov
reviewed
Sep 26, 2019
Differentiate types of HTTP proxies. Co-Authored-By: Andrew Svetlov <[email protected]>
|
thanks! |
asvetlov
pushed a commit
that referenced
this pull request
Sep 27, 2019
* Update docs to clarify proxy support Clarify that, while aiohttp supports proxies that upgrade to HTTPS via CONNECT, it doesn't support proxies that must be connected to via `https://` - #4100 . * Create 1400.doc Record change * Update docs/client_advanced.rst Differentiate types of HTTP proxies. Co-Authored-By: Andrew Svetlov <[email protected]> (cherry picked from commit be95c61) Co-authored-by: Benjamin Kane <[email protected]>
|
Thank you! |
asvetlov
added a commit
that referenced
this pull request
Sep 27, 2019
Clarify that, while aiohttp supports proxies that upgrade to HTTPS via CONNECT, it doesn't support proxies that must be connected to via `https://` - #4100 . Co-Authored-By: Andrew Svetlov <[email protected]> (cherry picked from commit be95c61) Co-authored-by: Benjamin Kane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify that, while aiohttp supports proxies that upgrade to HTTPS via CONNECT, it doesn't support proxies that must be connected to via
https://- #4100 .I had trouble building the library (
cchardetwoudn't compile), so I was unable to preview the docs. Please review for RST syntax errors.What do these changes do?
Update docs
Are there changes in behavior for the user?
None
Related issue number
Fixes #4100
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.