Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs to say aiohttp doesn't support HTTPS proxies #4100

Closed
bbkane opened this issue Sep 25, 2019 · 5 comments · Fixed by #4101
Closed

Update docs to say aiohttp doesn't support HTTPS proxies #4100

bbkane opened this issue Sep 25, 2019 · 5 comments · Fixed by #4101
Labels
pr-merged

Comments

@bbkane
Copy link
Contributor

bbkane commented Sep 25, 2019

Long story short

The docs say aiohttp supports HTTPS proxies, but the library raises an exception on HTTPS proxies, and there is issue to add support for them.

Expected behaviour

The docs shouldn't say HTTPS proxies are supported.

Actual behaviour

The docs say HTTPS proxies are supported.
@asvetlov
Copy link
Member

It doesn't support proxies that require https:// for connection to.
But proxy that can be connected by http:// with upgrade to HTTPS by CONNECT HTTP method is supported.

@bbkane
Copy link
Contributor Author

bbkane commented Sep 25, 2019

YES THATS WORKING!!! Please do update the docs to specify that though.

@asvetlov
Copy link
Member

Would you prepare a pull request?
I believe now you can rephrase the text to avoid any misunderstanding.

@bbkane
Copy link
Contributor Author

bbkane commented Sep 25, 2019 via email

@bbkane bbkane mentioned this issue Sep 26, 2019
Merged
5 tasks
@bbkane
Copy link
Contributor Author

bbkane commented Sep 26, 2019

Created #4101

@helpr helpr bot added the pr-available label Sep 26, 2019
asvetlov added a commit that referenced this issue Sep 27, 2019
@bbkane @asvetlov
Update docs to clarify proxy support (#4101)
be95c61 
* Update docs to clarify proxy support 

Clarify that, while aiohttp supports proxies that upgrade to HTTPS via CONNECT, it doesn't support proxies that must be connected to via `https://` - #4100 .

* Create 1400.doc

Record change

* Update docs/client_advanced.rst

Differentiate types of HTTP proxies.

Co-Authored-By: Andrew Svetlov <[email protected]>
@helpr helpr bot added pr-merged and removed pr-available labels Sep 27, 2019
asvetlov pushed a commit that referenced this issue Sep 27, 2019
@bbkane @asvetlov
[3.6] Update docs to clarify proxy support (#4101)
9a3329f 
* Update docs to clarify proxy support

Clarify that, while aiohttp supports proxies that upgrade to HTTPS via CONNECT, it doesn't support proxies that must be connected to via `https://` - #4100 .

* Create 1400.doc

Record change

* Update docs/client_advanced.rst

Differentiate types of HTTP proxies.

Co-Authored-By: Andrew Svetlov <[email protected]>
(cherry picked from commit be95c61)

Co-authored-by: Benjamin Kane <[email protected]>
@asvetlov asvetlov mentioned this issue Sep 27, 2019
Merged
asvetlov added a commit that referenced this issue Sep 27, 2019
@asvetlov @bbkane
[3.6] Update docs to clarify proxy support (#4101) (#4110)
8f039dc 
Clarify that, while aiohttp supports proxies that upgrade to HTTPS via CONNECT, it doesn't support proxies that must be connected to via `https://` - #4100 .

Co-Authored-By: Andrew Svetlov <[email protected]>
(cherry picked from commit be95c61)

Co-authored-by: Benjamin Kane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update docs to clarify proxy support
2 participants
@asvetlov @bbkane