Don't depend on Cython in setup.py #3694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
webknjaz
requested changes
Apr 15, 2019
webknjaz
reviewed
Apr 15, 2019
webknjaz
reviewed
May 8, 2019
webknjaz
approved these changes
May 9, 2019
asvetlov
added a commit
that referenced
this pull request
May 10, 2019
(cherry picked from commit ab0e956) Co-authored-by: Andrew Svetlov <[email protected]>
asvetlov
added a commit
that referenced
this pull request
May 10, 2019
(cherry picked from commit ab0e956) Co-authored-by: Andrew Svetlov <[email protected]>
|
@asvetlov we forgot about manylinux1 |
|
Do you mean that build of manylinux wheels doesn't compile cython source files? |
|
@asvetlov yes, because we don't rely on make there (and shouldn't) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3581
See also #3693
The PR is an alternative to #3589