-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Install Cython in isolated env using fortunate-pkg #3589
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Oh, and that might also need to go through the PEP process first to get a standard name for such optional requirement option + having "ignoring logic" requires some dynamic code which is not really a part of PEP 517 / PEP 518. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@asvetlov @samuelcolvin @kxepal So I'm investigating ways of shipping the build script within this repo. So what do you think? Should I rely on intreehooks shim or hack it all within aiohttp repo? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…in-isolated-pip-env
I think the PR can be closed: we use an alternative solution for cython sources translation. |
Okay, I can always restore this if needed. |
The source code of "try pip install" is @ https://github.com/webknjaz/fortunate-pkg
because I thought it might be useful for other projectsbecause it's the only reliable and pip-implemented way of invoking PEP 517 build backend.What do these changes do?
This basically adds
fortunate-pkg
as a requisite ofbuild-system
(PEP 517 / PEP 518).Then,
setup.py
uses it to triggerpip install cython
and ignore the result. So it would installCython
into an isolated build env created by Pip only if the user's OS has the build toolchain available (GCC in particular) and if it succeeds to compile Cython.Are there changes in behavior for the user?
With modern pip they don't have to care about pre-installing cython req manually.
Related issue number
This PoC should fix #3581 but needs futher discussion.
cc @pradyunsg plz participate
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.