Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: unix_sockname: use tmp_path #3555

Merged
merged 1 commit into from
May 13, 2019
Merged

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jan 19, 2019

Ref: #3551

The intention from/in #3551 is not really clear to me.

Mainly via #3553 (comment), but should be done in other places then also?

@asvetlov
Please consider picking it up.

@codecov-io
Copy link

codecov-io commented Jan 19, 2019

Codecov Report

Merging #3555 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3555   +/-   ##
=======================================
  Coverage   97.91%   97.91%           
=======================================
  Files          43       43           
  Lines        8577     8577           
  Branches     1384     1384           
=======================================
  Hits         8398     8398           
  Misses         74       74           
  Partials      105      105

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94e7b49...acf90ad. Read the comment docs.

2 similar comments
@codecov-io
Copy link

Codecov Report

Merging #3555 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3555   +/-   ##
=======================================
  Coverage   97.91%   97.91%           
=======================================
  Files          43       43           
  Lines        8577     8577           
  Branches     1384     1384           
=======================================
  Hits         8398     8398           
  Misses         74       74           
  Partials      105      105

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94e7b49...acf90ad. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Jan 19, 2019

Codecov Report

Merging #3555 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3555   +/-   ##
=======================================
  Coverage   97.91%   97.91%           
=======================================
  Files          43       43           
  Lines        8577     8577           
  Branches     1384     1384           
=======================================
  Hits         8398     8398           
  Misses         74       74           
  Partials      105      105

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94e7b49...acf90ad. Read the comment docs.

@asvetlov
Copy link
Member

Yes, the intention is replacing tmpdir with tmp_path everywhere in tests folder.
Consider the work as housekeeping, we need to do such tasks periodically.
py.path is great but pathlib is a part of standard batteries, it is much better known.

@asvetlov asvetlov merged commit 9c2c077 into aio-libs:master May 13, 2019
@asvetlov
Copy link
Member

Thanks!

@blueyed blueyed deleted the tmp_path branch May 13, 2019 15:07
@lock lock bot added the outdated label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants