Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace tmpdir fixture with tmp_path in tests #3551

Closed
asvetlov opened this issue Jan 17, 2019 · 2 comments · Fixed by #3955
Closed

Replace tmpdir fixture with tmp_path in tests #3551

asvetlov opened this issue Jan 17, 2019 · 2 comments · Fixed by #3955
Labels
good first issue Good for newcomers pr-merged

Comments

@asvetlov
Copy link
Member

I always stumble on py.path methods.
A new pytest supports tmp_path fixture https://docs.pytest.org/en/latest/tmpdir.html#the-tmp-path-factory-fixture to work with pathlib.Path.

The issue is easy and waits for a champion.
@asvetlov asvetlov added the good first issue Good for newcomers label Jan 17, 2019
@aio-libs-bot
Copy link

GitMate.io thinks possibly related issues are #1459 (Tests for demo polls app fail with "fixture 'event_loop' not found"), #2148 (Failed tests), #304 (multipart tests), #858 (replace http parser?), and #1583 (normalize_path_middleware tests failures).

theruziev pushed a commit to theruziev/aiohttp that referenced this issue Jan 18, 2019
Replace tmpdir fixture with tmp_path in tests (aio-libs#3551)
c304754
@theruziev theruziev mentioned this issue Jan 18, 2019
Merged
asvetlov pushed a commit that referenced this issue Jan 19, 2019
@theruziev @asvetlov
Replace tmpdir fixture with tmp_path in tests (#3551) (#3553)
94e7b49
blueyed added a commit to blueyed/aiohttp that referenced this issue Jan 19, 2019
@blueyed
tests: unix_sockname: use tmp_path
acf90ad 
Ref: aio-libs#3551
@blueyed blueyed mentioned this issue Jan 19, 2019
Merged
@gyermolenko
Copy link
Contributor

gyermolenko commented Jan 31, 2019 •
edited
Loading

I found it relevant to current issue, adding for context: ref pytest-dev/pytest#4680 and two other tmp_path defects were fixed in pytest 4.2.
And pytest 4.2 has just beed released.

asvetlov pushed a commit that referenced this issue May 13, 2019
@blueyed @asvetlov
tests: unix_sockname: use tmp_path (#3555)
9c2c077 
Ref: #3551
@vaneseltine vaneseltine mentioned this issue Aug 2, 2019
Merged
@helpr helpr bot added the pr-available label Aug 2, 2019
@helpr helpr bot added pr-merged and removed pr-available labels Aug 2, 2019
asvetlov pushed a commit that referenced this issue Aug 2, 2019
@vaneseltine @asvetlov
Replace all tmpdir fixtures with tmp_path (#3551) (#3955)
8960063 
tmp_path is the replacement fixture in pytest for tmpdir; tmp_path
uses the builtin pathlib.Path class. As it says on the tin, this
commit replaces every instance of tmpdir in the test suite with
tmp_path. Aside from s/tmpdir/tmp_path/ this also required changing
instances of `tmpdir.join(foo)` to `tmp_path / foo`.

This is intended to comprehensively address #3551 and should have
no side effects.
webknjaz pushed a commit to webknjaz/aiohttp that referenced this issue Jan 28, 2024
@vaneseltine @webknjaz
Replace all tmpdir fixtures with tmp_path (aio-libs#3551) (aio-libs#3955
739f6db 
)

tmp_path is the replacement fixture in pytest for tmpdir; tmp_path
uses the builtin pathlib.Path class. As it says on the tin, this
commit replaces every instance of tmpdir in the test suite with
tmp_path. Aside from s/tmpdir/tmp_path/ this also required changing
instances of `tmpdir.join(foo)` to `tmp_path / foo`.

This is intended to comprehensively address aio-libs#3551 and should have
no side effects.

(cherry picked from commit 8960063)
webknjaz pushed a commit to webknjaz/aiohttp that referenced this issue Jan 28, 2024
@vaneseltine @webknjaz
Replace all tmpdir fixtures with tmp_path (aio-libs#3551) (aio-libs#3955
a874ba4 
)

tmp_path is the replacement fixture in pytest for tmpdir; tmp_path
uses the builtin pathlib.Path class. As it says on the tin, this
commit replaces every instance of tmpdir in the test suite with
tmp_path. Aside from s/tmpdir/tmp_path/ this also required changing
instances of `tmpdir.join(foo)` to `tmp_path / foo`.

This is intended to comprehensively address aio-libs#3551 and should have
no side effects.

(cherry picked from commit 8960063)
This was referenced Jan 28, 2024
Merged
Merged
webknjaz pushed a commit to webknjaz/aiohttp that referenced this issue Jan 28, 2024
@vaneseltine @webknjaz
Replace all tmpdir fixtures with tmp_path (aio-libs#3551) (aio-libs#3955
01a386c 
)

tmp_path is the replacement fixture in pytest for tmpdir; tmp_path
uses the builtin pathlib.Path class. As it says on the tin, this
commit replaces every instance of tmpdir in the test suite with
tmp_path. Aside from s/tmpdir/tmp_path/ this also required changing
instances of `tmpdir.join(foo)` to `tmp_path / foo`.

This is intended to comprehensively address aio-libs#3551 and should have
no side effects.

(cherry picked from commit 8960063)
webknjaz pushed a commit to webknjaz/aiohttp that referenced this issue Jan 28, 2024
@vaneseltine @webknjaz
Replace all tmpdir fixtures with tmp_path (aio-libs#3551) (aio-libs#3955
486585c 
)

tmp_path is the replacement fixture in pytest for tmpdir; tmp_path
uses the builtin pathlib.Path class. As it says on the tin, this
commit replaces every instance of tmpdir in the test suite with
tmp_path. Aside from s/tmpdir/tmp_path/ this also required changing
instances of `tmpdir.join(foo)` to `tmp_path / foo`.

This is intended to comprehensively address aio-libs#3551 and should have
no side effects.

(cherry picked from commit 8960063)
webknjaz added a commit that referenced this issue Jan 28, 2024
@webknjaz @vaneseltine
[PR #3955/8960063e backport][3.10] Replace all tmpdir fixtures with t…
bb59070 
…mp_path (#3551) (#8075)

**This is a backport of PR #3955 as merged into master
(8960063).**

tmp_path is the replacement fixture in pytest for tmpdir; tmp_path
uses the builtin pathlib.Path class. As it says on the tin, this
commit replaces every instance of tmpdir in the test suite with
tmp_path. Aside from s/tmpdir/tmp_path/ this also required changing
instances of `tmpdir.join(foo)` to `tmp_path / foo`.

This is intended to comprehensively address and close #3551, and
should have no side effects. This does not affect end users.

Co-authored-by: Matt VanEseltine <[email protected]>
webknjaz added a commit that referenced this issue Jan 28, 2024
@webknjaz @vaneseltine
[PR #3955/8960063e backport][3.9] Replace all tmpdir fixtures with tm…
435ad46 
…p_path (#3551) (#8076)

**This is a backport of PR #3955 as merged into master
(8960063).**

tmp_path is the replacement fixture in pytest for tmpdir; tmp_path
uses the builtin pathlib.Path class. As it says on the tin, this
commit replaces every instance of tmpdir in the test suite with
tmp_path. Aside from s/tmpdir/tmp_path/ this also required changing
instances of `tmpdir.join(foo)` to `tmp_path / foo`.

This is intended to comprehensively address and close #3551, and
should have no side effects. This does not affect end users.

Co-authored-by: Matt VanEseltine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace all tmpdir fixtures with tmp_path (#3551)
3 participants
@asvetlov @gyermolenko @aio-libs-bot