Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #2000

Merged
merged 6 commits into from
Jun 22, 2017
Merged

Fix tests #2000

merged 6 commits into from
Jun 22, 2017

Conversation

asvetlov
Copy link
Member

Fix #1994

@fafhrd91
Copy link
Member

Nice PR number :)

@asvetlov
Copy link
Member Author

A lot of work since 2013.
Unbelievable, the project will celebrate 4 years this Autumn.

@codecov-io
Copy link

codecov-io commented Jun 22, 2017 •
edited
Loading

Codecov Report

Merging #2000 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2000   +/-   ##
=======================================
  Coverage   97.04%   97.04%           
=======================================
  Files          38       38           
  Lines        7679     7679           
  Branches     1341     1341           
=======================================
  Hits         7452     7452           
  Misses        102      102           
  Partials      125      125
Impacted Files Coverage Δ
aiohttp/client_reqrep.py 97.19% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f2adac...0ab94f9. Read the comment docs.

@asvetlov asvetlov merged commit 075c34c into master Jun 22, 2017
@asvetlov asvetlov deleted the fix_tests branch June 22, 2017 17:28
@fafhrd91
Copy link
Member

time flies

@socketpair socketpair mentioned this pull request Jul 31, 2017
Closed
asvetlov added a commit that referenced this pull request Aug 2, 2017
@asvetlov
Adopt to multidict 3.0.0 (#2000)
60574a6 
* Fix couple tests

* Another test

* Fix last tests

* Pin multidict requirement to 3.0.0

* Fix tests

* Make test stable
@asvetlov asvetlov mentioned this pull request Oct 21, 2017
Closed
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to new multidict version
3 participants
@asvetlov @fafhrd91 @codecov-io