Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to new multidict version #1994

Closed
asvetlov opened this issue Jun 20, 2017 · 2 comments · Fixed by #2000
Closed

Switch to new multidict version #1994

asvetlov opened this issue Jun 20, 2017 · 2 comments · Fixed by #2000
Labels
outdated
Milestone
2.3

Comments

@asvetlov
Copy link
Member

Current multidict master has changed behavior: keys for CIMultiDict are always str (before they was either str or istr) and they are stored as-is without title casing. But key comparison is performed on title-cased basis.

Also CIMultiDict lookup is about 30% faster.

It is backward incompatible change, some aiohttp tests are failing. But all functionality is working on just released aiohttp 2.2.0 (it's crucial for smooth transition).

I need release new multidict first and fix failed aiohttp tests.
@asvetlov asvetlov added this to the 2.3.0 milestone Jun 20, 2017
@asvetlov
Copy link
Member Author

multidict 3.0.0 has released

@asvetlov asvetlov mentioned this issue Jun 21, 2017
Merged
@asvetlov asvetlov mentioned this issue Oct 21, 2017
Closed
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
2.3
Development

Successfully merging a pull request may close this issue.

Fix tests aio-libs/aiohttp
1 participant
@asvetlov