Pass falsy data to ClientRequest.update_body_from_data handler #143
Conversation
While logic of processing only "true" values to form request body is ok
for plain raw requests, it causes troubles when you inherit from
ClientRequest to produce requests for some specific content type.
For instance, it's ok to pass "falsy" `0`, `False`, `{}` data if you're
implementing JsonClientRequest class that automatically encodes data
inside update_body_from_data method.
|
I think we should use some marker object (empty data) and skip 'data' processing for if default value is specified |
|
Agree with @fafhrd91 |
|
What's the point for sentinel for no data? And how to handle the data then if it suddenly starts to be |
|
if data is not provided we do not want to attach default value to request. |
|
That's clear. I asked about reason of it in light of the fact that method cannot process same None value - you should overload this method and add own logic about. Also, if you has any wrapper around |
|
ok, that makes sense. |
|
+1 |
Pass falsy data to ClientRequest.update_body_from_data handler
While logic of processing only "true" values to form request body is ok
for plain raw requests, it causes troubles when you inherit from
ClientRequest to produce requests for some specific content type.
For instance, it's ok to pass "falsy"
0,False,{}data if you'reimplementing JsonClientRequest class that automatically encodes data
inside update_body_from_data method.