Merge pull request #143 from kxepal/handle-falsy-data-on-request

Pass falsy data to ClientRequest.update_body_from_data handler

aiohttp/client.py

@@ -205,9 +205,7 @@ def __init__(self, method, url, *,
                     'not supported at the same time.')
             data = files
 
-        if data:
-            self.update_body_from_data(data)
-
+        self.update_body_from_data(data)
         self.update_transfer_encoding()
         self.update_expect_continue(expect100)
 
@@ -355,6 +353,9 @@ def update_auth(self, auth):
         self.headers['AUTHORIZATION'] = auth.encode()
 
     def update_body_from_data(self, data):
+        if not data:
+            return
+
         if isinstance(data, str):
             data = data.encode(self.encoding)
 

tests/test_client.py

@@ -504,6 +504,13 @@ def test_post_data(self):
             self.assertEqual('application/x-www-form-urlencoded',
                              req.headers['CONTENT-TYPE'])
 
+    @unittest.mock.patch('aiohttp.client.ClientRequest.update_body_from_data')
+    def test_pass_falsy_data(self, _):
+        req = ClientRequest(
+            'post', 'http://python.org/',
+            data={}, loop=self.loop)
+        req.update_body_from_data.assert_called_once_with({})
+
     def test_get_with_data(self):
         for meth in ClientRequest.GET_METHODS:
             req = ClientRequest(