Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #10122/703ce61 backport][3.11] Typing improvements for file responses #10123

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 5, 2024

(cherry picked from commit 703ce61)

@bdraco bdraco changed the title Typing improvements for file responses (#10122) [PR #10122/703ce61 backport][3.11] Typing improvements for file responses Dec 5, 2024
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Dec 5, 2024
@bdraco bdraco marked this pull request as ready for review December 5, 2024 19:34
@bdraco bdraco requested a review from asvetlov as a code owner December 5, 2024 19:34
Copy link

codspeed-hq bot commented Dec 5, 2024

CodSpeed Performance Report

Merging #10123 will not alter performance

Comparing patchback/backports/3.11/703ce6172f55e959cc7a0c2dd7a4fe7170e0590e/pr-10122 (bd1e623) with 3.11 (bcae561)

Summary

✅ 47 untouched benchmarks

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (bcae561) to head (bd1e623).
Report is 1 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.11   #10123      +/-   ##
==========================================
- Coverage   98.06%   98.06%   -0.01%     
==========================================
  Files         123      123              
  Lines       37147    37144       -3     
  Branches     4467     4465       -2     
==========================================
- Hits        36430    36426       -4     
  Misses        540      540              
- Partials      177      178       +1     
Flag Coverage Δ
CI-GHA 97.95% <100.00%> (-0.01%) ⬇️
OS-Linux 97.66% <100.00%> (-0.01%) ⬇️
OS-Windows 94.58% <100.00%> (-0.01%) ⬇️
OS-macOS 96.77% <100.00%> (-0.01%) ⬇️
Py-3.10.11 96.63% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.17% <100.00%> (-0.04%) ⬇️
Py-3.11.10 97.28% <100.00%> (+0.05%) ⬆️
Py-3.11.9 96.70% <100.00%> (+0.01%) ⬆️
Py-3.12.7 97.72% <100.00%> (-0.01%) ⬇️
Py-3.13.0 96.55% <100.00%> (-0.01%) ⬇️
Py-3.13.1 97.69% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.56% <100.00%> (-0.01%) ⬇️
Py-3.9.20 97.13% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 96.69% <100.00%> (+<0.01%) ⬆️
VM-macos 96.77% <100.00%> (-0.01%) ⬇️
VM-ubuntu 97.66% <100.00%> (-0.01%) ⬇️
VM-windows 94.58% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco enabled auto-merge (squash) December 5, 2024 19:41
@bdraco bdraco merged commit db5e6bb into 3.11 Dec 5, 2024
33 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/703ce6172f55e959cc7a0c2dd7a4fe7170e0590e/pr-10122 branch December 5, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant