Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing improvements for file responses #10122

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 5, 2024

When I was working on this in #10113 and #10101 I found there was quite a bit of missing typing which made it a bit harder to validate changes.

Add some more typing here to ensure everything is working as expected

@bdraco bdraco requested a review from asvetlov as a code owner December 5, 2024 19:19
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.76%. Comparing base (0130213) to head (6e9512d).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10122      +/-   ##
==========================================
- Coverage   98.76%   98.76%   -0.01%     
==========================================
  Files         122      122              
  Lines       36961    36958       -3     
  Branches     4410     4408       -2     
==========================================
- Hits        36503    36500       -3     
  Misses        311      311              
  Partials      147      147              
Flag Coverage Δ
CI-GHA 98.64% <100.00%> (-0.01%) ⬇️
OS-Linux 98.33% <100.00%> (-0.01%) ⬇️
OS-Windows 96.18% <100.00%> (-0.01%) ⬇️
OS-macOS 97.43% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.28% <100.00%> (-0.01%) ⬇️
Py-3.10.15 97.82% <100.00%> (-0.01%) ⬇️
Py-3.11.10 97.86% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.33% <100.00%> (-0.01%) ⬇️
Py-3.12.7 98.39% <100.00%> (-0.01%) ⬇️
Py-3.13.0 97.19% <100.00%> (-0.01%) ⬇️
Py-3.13.1 98.35% <100.00%> (-0.01%) ⬇️
Py-3.9.13 97.20% <100.00%> (-0.01%) ⬇️
Py-3.9.20 97.78% <100.00%> (+0.04%) ⬆️
Py-pypy7.3.16 97.35% <100.00%> (-0.01%) ⬇️
VM-macos 97.43% <100.00%> (-0.01%) ⬇️
VM-ubuntu 98.33% <100.00%> (-0.01%) ⬇️
VM-windows 96.18% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 5, 2024

CodSpeed Performance Report

Merging #10122 will not alter performance

Comparing typing_web_file_response (6e9512d) with master (0130213)

Summary

✅ 47 untouched benchmarks

@bdraco bdraco enabled auto-merge (squash) December 5, 2024 19:26
@bdraco bdraco merged commit 703ce61 into master Dec 5, 2024
40 checks passed
@bdraco bdraco deleted the typing_web_file_response branch December 5, 2024 19:30
Copy link
Contributor

patchback bot commented Dec 5, 2024

Backport to 3.11: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 703ce61 on top of patchback/backports/3.11/703ce6172f55e959cc7a0c2dd7a4fe7170e0590e/pr-10122

Backporting merged PR #10122 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.11/703ce6172f55e959cc7a0c2dd7a4fe7170e0590e/pr-10122 upstream/3.11
  4. Now, cherry-pick PR Typing improvements for file responses #10122 contents into that branch:
    $ git cherry-pick -x 703ce6172f55e959cc7a0c2dd7a4fe7170e0590e
    If it'll yell at you with something like fatal: Commit 703ce6172f55e959cc7a0c2dd7a4fe7170e0590e is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 703ce6172f55e959cc7a0c2dd7a4fe7170e0590e
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Typing improvements for file responses #10122 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.11/703ce6172f55e959cc7a0c2dd7a4fe7170e0590e/pr-10122
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Dec 5, 2024

Backport to 3.12: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 703ce61 on top of patchback/backports/3.12/703ce6172f55e959cc7a0c2dd7a4fe7170e0590e/pr-10122

Backporting merged PR #10122 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.12/703ce6172f55e959cc7a0c2dd7a4fe7170e0590e/pr-10122 upstream/3.12
  4. Now, cherry-pick PR Typing improvements for file responses #10122 contents into that branch:
    $ git cherry-pick -x 703ce6172f55e959cc7a0c2dd7a4fe7170e0590e
    If it'll yell at you with something like fatal: Commit 703ce6172f55e959cc7a0c2dd7a4fe7170e0590e is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 703ce6172f55e959cc7a0c2dd7a4fe7170e0590e
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Typing improvements for file responses #10122 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.12/703ce6172f55e959cc7a0c2dd7a4fe7170e0590e/pr-10122
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

bdraco added a commit that referenced this pull request Dec 5, 2024
bdraco added a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant