-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typing improvements for file responses #10122
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #10122 +/- ##
==========================================
- Coverage 98.76% 98.76% -0.01%
==========================================
Files 122 122
Lines 36961 36958 -3
Branches 4410 4408 -2
==========================================
- Hits 36503 36500 -3
Misses 311 311
Partials 147 147
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #10122 will not alter performanceComparing Summary
|
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 703ce61 on top of patchback/backports/3.11/703ce6172f55e959cc7a0c2dd7a4fe7170e0590e/pr-10122 Backporting merged PR #10122 into master
🤖 @patchback |
Backport to 3.12: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 703ce61 on top of patchback/backports/3.12/703ce6172f55e959cc7a0c2dd7a4fe7170e0590e/pr-10122 Backporting merged PR #10122 into master
🤖 @patchback |
(cherry picked from commit 703ce61)
(cherry picked from commit 703ce61)
When I was working on this in #10113 and #10101 I found there was quite a bit of missing typing which made it a bit harder to validate changes.
Add some more typing here to ensure everything is working as expected