-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protocols: Add usage of metadata/paral. overrides #652
Protocols: Add usage of metadata/paral. overrides #652
Conversation
fb0cbc0
to
002da7a
Compare
002da7a
to
ffc373f
Compare
ffc373f
to
1a6278a
Compare
@sphuber although I think the comment in your review is valid, I will open a separate PR to deal with the possibility of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok to merge as is @mbercx . Would it be possible to add a quick test that the metadata and parallelization are now respected by the get_builder_from _protocol
?
The `metadata` and `parallelization` inputs of the `PwCalculation`, stored in the `pw` namespace of the `PwBaseWorkChain`, are not (properly) used in the `get_builder_from_protocol()` method. Here we make the following changes to correct this issue: * Move the `metadata` inputs under `pw` in the base.yaml file. * Correctly obtain the `metadata` from the inputs in the `get_builder_from_protocol()` method of the `PwBaseWorkChain`. * Check if there is `parallelization` input in the `pw` namespace of the inputs, and if so add it to the builder in the `get_builder_from_protocol()` method of the `PwBaseWorkChain`.
1a6278a
to
1bd67b4
Compare
2 addition tests, coming right up! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #651
The
metadata
andparallelization
inputs of thePwCalculation
,stored in the
pw
namespace of thePwBaseWorkChain
, are not(properly) used in the
get_builder_from_protocol()
method. Here wemake the following changes to correct this issue:
metadata
inputs underpw
in the base.yaml file.metadata
from the inputs in theget_builder_from_protocol()
method of thePwBaseWorkChain
.parallelization
input in thepw
namespace of theinputs, and if so add it to the builder in the
get_builder_from_protocol()
method of thePwBaseWorkChain
.