Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocols: metadata and parallelization overrides not used #651

Closed
mbercx opened this issue Feb 18, 2021 · 0 comments · Fixed by #652
Closed

Protocols: metadata and parallelization overrides not used #651

mbercx opened this issue Feb 18, 2021 · 0 comments · Fixed by #652
Assignees
Milestone

Comments

@mbercx
Copy link
Member

mbercx commented Feb 18, 2021

Currently, the metadata and parallelization settings in the overrides supplied to the get_builder_from_protocol() method are not used (properly). In case of the metadata, these are ignored because of this line:

builder.pw['metadata'] = inputs['metadata'] # pylint: disable=no-member

When the user provides the metadata correctly, in the pw namespace, they are not used. The defaults are still loaded because the .yaml file is incorrect.

The parallelization overrides are not used at all in the get_builder_from_protocol() method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant