Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate arch builds with different rabbitmq start file #52

Merged
merged 2 commits into from
Jul 28, 2022
Merged

Separate arch builds with different rabbitmq start file #52

merged 2 commits into from
Jul 28, 2022

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Jul 27, 2022

The attempt to separate build for arm64 and amd64 more independent so they can use different ways to set up rabbitmq. Required by #50.

yakutovicha
yakutovicha approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot @unkcpz!

@yakutovicha yakutovicha merged commit 6cf4e9f into aiidateam:develop Jul 28, 2022
@unkcpz unkcpz deleted the seperate-arch-build branch July 28, 2022 11:53
@yakutovicha yakutovicha mentioned this pull request Jul 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yakutovicha yakutovicha yakutovicha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unkcpz @yakutovicha