-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move RabbitMQ to a dedicated conda environment. #50
Conversation
301402b
to
6e578d8
Compare
02b5611
to
d2f2574
Compare
e77bc19
to
86c3d70
Compare
Update rabbitmq test, set rmq version to 3.8.14 Add some comments to my_init.d/start-rabbitmq.sh
86c3d70
to
28fab87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yakutovicha thanks! Looks good to me and not sure why test failed. Seems like the rabbitmq from conda not properly started.
Instead of blocking you moving forward to migrate to aiida 2.0, I'll approve this once CI test passes and test it for arm64 on my computer next week.
@@ -47,14 +47,14 @@ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-ins | |||
RUN apt-get update && apt-get install -y --no-install-recommends \ | |||
build-essential \ | |||
bzip2 \ | |||
erlang \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this? I think conda for rabbitmq will take care of the correct version of erlang and apt install of rabbitmq-server for arm64 will install this with required version https://www.rabbitmq.com/install-debian.html#apt-quick-start-cloudsmith.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is what I was hoping for. But it didn't work, unfortunately :(. I will create an issue about that hack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here is the issue: #58
# Copy the script load-singlesshagent.sh to /usr/local/bin. | ||
COPY bin/load-singlesshagent.sh /usr/local/bin/load-singlesshagent.sh | ||
|
||
# Create system user. | ||
COPY my_init.d/create-system-user.sh /etc/my_init.d/10_create-system-user.sh | ||
|
||
# Launch rabbitmq server | ||
COPY my_init.d/start-rabbitmq-${TARGETARCH}.sh /etc/my_init.d/20_start-rabbitmq.sh | ||
COPY opt/start-rabbitmq-${TARGETARCH}.sh /opt/start-rabbitmq.sh | ||
COPY my_init.d/start-rabbitmq.sh /etc/my_init.d/20_start-rabbitmq.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused with these.
Ah, I see. The /opt/start-rabbitmq.sh
will be different for arm64 and amd64, and start-rabbitmq.sh will used for both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. The
/opt/start-rabbitmq.sh
will be different for arm64 and amd64, and start-rabbitmq.sh will used for both?
yep!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
fixes #39