-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install PostgreSQL into pgsql
conda environment.
#49
Install PostgreSQL into pgsql
conda environment.
#49
Conversation
@yakutovicha Looks like you need to update the branch? |
023d3a1
to
52e74a5
Compare
and downgrade PostgreSQL :) |
Indeed, it is actually not quite clear to me what exactly this PR is trying to achieve. To my understanding it is perfectly fine to use the OS-provided distribution of PGSQL as our main database process, we just need the second installation for the migration. However, this PR seems to generally install PGSQL via conda. Why? |
Well, I wrote the motivation in the issue. The only thing that I could add is that PGSQL=10 is not available in Ubuntu 20/22. |
But aren't you replacing the main database installation here which we actually want to be a newer one that is supported by Ubuntu 20/22? |
I would like to downgrade the PGSQL to version 10 because this version is used in all stable AiiDAlab images out there. Once this PR is merged I am going to immediately release a new At the same time, I will continue solving the migration issue. I hope that makes sense |
Unfortunately, not. You say that this effort is part of #44 which is about creating the migration. Why would we need to downgrade for that? We only need a second installation with an older version, no? Further, you convinced me yesterday that we should press forward with the migration and that trying to get back into a good state on the aiidalab image does not really make sense. Especially since we can always create a new aiidalab image release by simply basing it on an older version of the aiida-core image (e.g. via aiidalab/aiidalab-docker-stack#270). So we don't need to downgrade the database for the migration nor for creating a new aiidalab release. 😕 |
dcbf3a1
to
c37d24a
Compare
Install PGSQL=10 into dedicated conda environment to be compatible with the stable AiiDA/AiiDAlab images out there.
fixes #48